[Mailman-Developers] cosmetic bug in order of held messages

Barry A. Warsaw bwarsaw@cnri.reston.va.us
Thu, 13 Apr 2000 18:08:44 -0400 (EDT)


>>>>> "TW" == Thomas Wouters <thomas@xs4all.net> writes:

    TW> The problem is caused by the way pending admin requests
    TW> are stored: in a dictionary, with sequential id's as the key.
    TW> Adding a 'ids.sort()' before 'return ids' in __getmsgids() (in
    TW> ListAdmin.py) solves the problem for the most part, and keeps
    TW> my boss happily playing with his pet project ;)

    TW> Should I bother sending a patch ?

Naw.  See below.
-Barry

Index: ListAdmin.py
===================================================================
RCS file: /projects/cvsroot/mailman/Mailman/ListAdmin.py,v
retrieving revision 1.29
diff -c -r1.29 ListAdmin.py
*** ListAdmin.py	2000/04/08 17:12:22	1.29
--- ListAdmin.py	2000/04/13 22:03:14
***************
*** 98,103 ****
--- 98,104 ----
          for k, (type, data) in self.__db.items():
              if type == rtype:
                  ids.append(k)
+         ids.sort()
          return ids
  
      def GetHeldMessageIds(self):