[Python-checkins] gh-95950: Add a test for both `csv.Dialect` and `kwargs` (GH-95951)
miss-islington
webhook-mailer at python.org
Sun Aug 28 21:11:15 EDT 2022
https://github.com/python/cpython/commit/60f704f1258d8c225ad0a9ba3f342b553064206a
commit: 60f704f1258d8c225ad0a9ba3f342b553064206a
branch: 3.10
author: Miss Islington (bot) <31488909+miss-islington at users.noreply.github.com>
committer: miss-islington <31488909+miss-islington at users.noreply.github.com>
date: 2022-08-28T18:11:02-07:00
summary:
gh-95950: Add a test for both `csv.Dialect` and `kwargs` (GH-95951)
(cherry picked from commit 1c01bd28a0ec7e46e570a07d970c590b1809f8f1)
Co-authored-by: Nikita Sobolev <mail at sobolevn.me>
files:
M Lib/test/test_csv.py
diff --git a/Lib/test/test_csv.py b/Lib/test/test_csv.py
index 6e5dfc63d43..d94a6f24597 100644
--- a/Lib/test/test_csv.py
+++ b/Lib/test/test_csv.py
@@ -421,6 +421,34 @@ def test_register_kwargs(self):
self.assertEqual(csv.get_dialect(name).delimiter, ';')
self.assertEqual([['X', 'Y', 'Z']], list(csv.reader(['X;Y;Z'], name)))
+ def test_register_kwargs_override(self):
+ class mydialect(csv.Dialect):
+ delimiter = "\t"
+ quotechar = '"'
+ doublequote = True
+ skipinitialspace = False
+ lineterminator = '\r\n'
+ quoting = csv.QUOTE_MINIMAL
+
+ name = 'test_dialect'
+ csv.register_dialect(name, mydialect,
+ delimiter=';',
+ quotechar="'",
+ doublequote=False,
+ skipinitialspace=True,
+ lineterminator='\n',
+ quoting=csv.QUOTE_ALL)
+ self.addCleanup(csv.unregister_dialect, name)
+
+ # Ensure that kwargs do override attributes of a dialect class:
+ dialect = csv.get_dialect(name)
+ self.assertEqual(dialect.delimiter, ';')
+ self.assertEqual(dialect.quotechar, "'")
+ self.assertEqual(dialect.doublequote, False)
+ self.assertEqual(dialect.skipinitialspace, True)
+ self.assertEqual(dialect.lineterminator, '\n')
+ self.assertEqual(dialect.quoting, csv.QUOTE_ALL)
+
def test_incomplete_dialect(self):
class myexceltsv(csv.Dialect):
delimiter = "\t"
More information about the Python-checkins
mailing list