[Python-checkins] cpython (3.4): Issue #19884, readline: calling rl_variable_bind ("enable-meta-key", "off")

[victor.stinner]

http://hg.python.org/cpython/rev/3f08c1156050
changeset:   91836:3f08c1156050
branch:      3.4
parent:      91831:b7f144d14798
user:        Victor Stinner <victor.stinner at gmail.com>
date:        Thu Jul 24 22:11:38 2014 +0200
summary:
  Issue #19884, readline: calling rl_variable_bind ("enable-meta-key", "off")
does crash on Mac OS X which uses libedit instead of readline.

files:
  Modules/readline.c |  6 +++++-
  1 files changed, 5 insertions(+), 1 deletions(-)


diff --git a/Modules/readline.c b/Modules/readline.c
--- a/Modules/readline.c
+++ b/Modules/readline.c
@@ -1020,15 +1020,19 @@
     mod_state->begidx = PyLong_FromLong(0L);
     mod_state->endidx = PyLong_FromLong(0L);
 
+#ifndef __APPLE__
     if (!isatty(STDOUT_FILENO)) {
         /* Issue #19884: stdout is no a terminal. Disable meta modifier
            keys to not write the ANSI sequence "\033[1034h" into stdout. On
            terminals supporting 8 bit characters like TERM=xterm-256color
            (which is now the default Fedora since Fedora 18), the meta key is
            used to enable support of 8 bit characters (ANSI sequence
-           "\033[1034h"). */
+           "\033[1034h").
+
+           With libedit, this call makes readline() crash. */
         rl_variable_bind ("enable-meta-key", "off");
     }
+#endif
 
     /* Initialize (allows .inputrc to override)
      *

-- 
Repository URL: http://hg.python.org/cpython