[Python-checkins] cpython (2.7): Issue #19884, readline: calling rl_variable_bind ("enable-meta-key", "off")

victor.stinner python-checkins at python.org
Thu Jul 24 22:12:57 CEST 2014


http://hg.python.org/cpython/rev/f0ab6f9f0603
changeset:   91835:f0ab6f9f0603
branch:      2.7
parent:      91833:d422062d7d36
user:        Victor Stinner <victor.stinner at gmail.com>
date:        Thu Jul 24 22:11:21 2014 +0200
summary:
  Issue #19884, readline: calling rl_variable_bind ("enable-meta-key", "off")
does crash on Mac OS X which uses libedit instead of readline.

files:
  Modules/readline.c |  6 +++++-
  1 files changed, 5 insertions(+), 1 deletions(-)


diff --git a/Modules/readline.c b/Modules/readline.c
--- a/Modules/readline.c
+++ b/Modules/readline.c
@@ -933,15 +933,19 @@
     begidx = PyInt_FromLong(0L);
     endidx = PyInt_FromLong(0L);
 
+#ifndef __APPLE__
     if (!isatty(STDOUT_FILENO)) {
         /* Issue #19884: stdout is no a terminal. Disable meta modifier
            keys to not write the ANSI sequence "\033[1034h" into stdout. On
            terminals supporting 8 bit characters like TERM=xterm-256color
            (which is now the default Fedora since Fedora 18), the meta key is
            used to enable support of 8 bit characters (ANSI sequence
-           "\033[1034h"). */
+           "\033[1034h").
+
+           With libedit, this call makes readline() crash. */
         rl_variable_bind ("enable-meta-key", "off");
     }
+#endif
 
     /* Initialize (allows .inputrc to override)
      *

-- 
Repository URL: http://hg.python.org/cpython


More information about the Python-checkins mailing list