[Python-checkins] r51731 - python/trunk/Python/ast.c

[Nick Coghlan]

neal.norwitz wrote:
> +/* XXX(nnorwitz): the listcomp and genexpr code should be refactored
> +   so there is only a single version.  Possibly for loops can also re-use
> +   the code.
> +*/

I believe I tried to do exactly that back before the AST compiler landed on 
the trunk. As I recall, the code generated turned out to be sufficiently 
different in structure (a for loop instead of an anonymous generator function) 
that it didn't seem practical to combine them.

Then again, I wasn't that familiar with the AST code at the time, so maybe 
someone else will have more luck :)

Cheers,
Nick.

-- 
Nick Coghlan   |   ncoghlan at gmail.com   |   Brisbane, Australia
---------------------------------------------------------------
             http://www.boredomandlaziness.org