[Python-checkins] r51731 - python/trunk/Python/ast.c

neal.norwitz python-checkins at python.org
Tue Sep 5 05:58:27 CEST 2006


Author: neal.norwitz
Date: Tue Sep  5 05:58:26 2006
New Revision: 51731

Modified:
   python/trunk/Python/ast.c
Log:
Add a comment about some refactoring.  (There's probably more that should be done.)  I will reformat this file in the next checkin due to the inconsistent tabs/spaces.

Modified: python/trunk/Python/ast.c
==============================================================================
--- python/trunk/Python/ast.c	(original)
+++ python/trunk/Python/ast.c	Tue Sep  5 05:58:26 2006
@@ -15,12 +15,6 @@
 
 #include <assert.h>
 
-/* XXX TO DO
-   - re-indent this file (should be done)
-   - internal error checking (freeing memory, etc.)
-   - syntax errors
-*/
-
 /* Data structure used internally */
 struct compiling {
     char *c_encoding; /* source encoding */
@@ -889,6 +883,11 @@
                  c->c_arena);
 }
 
+/* XXX(nnorwitz): the listcomp and genexpr code should be refactored
+   so there is only a single version.  Possibly for loops can also re-use
+   the code.
+*/
+
 /* Count the number of 'for' loop in a list comprehension.
 
    Helper for ast_for_listcomp().


More information about the Python-checkins mailing list