[Pandas-dev] Pandas-dev Digest, Vol 120, Issue 2

Wed May 3 11:09:27 EDT 2023

Thanks all for your comments here, some good points have been raised!

The maintainers' guide
<https://pandas.pydata.org/docs/dev/development/maintaining.html> doesn't
have any guidelines around "needs triage", so I'll put something together
based on the points brought up here

On Wed, May 3, 2023 at 2:19 PM <pandas-dev-request at python.org> wrote:

> Send Pandas-dev mailing list submissions to
>         pandas-dev at python.org
>
> To subscribe or unsubscribe via the World Wide Web, visit
>         https://mail.python.org/mailman/listinfo/pandas-dev
> or, via email, send a message with subject or body 'help' to
>         pandas-dev-request at python.org
>
> You can reach the person managing the list at
>         pandas-dev-owner at python.org
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of Pandas-dev digest..."
>
>
> Today's Topics:
>
>    1. Re: Triage (Richard Shadrach)
>    2. Re: Triage (Simon Hawkins)
>
>
> ----------------------------------------------------------------------
>
> Message: 1
> Date: Wed, 3 May 2023 08:05:18 -0400
> From: Richard Shadrach <rhshadrach at gmail.com>
> To: Dea Mar?a <deamarialeon at gmail.com>
> Cc: Marc Garcia <garcia.marc at gmail.com>, pandas-dev
>         <pandas-dev at python.org>
> Subject: Re: [Pandas-dev] Triage
> Message-ID:
>         <CAJ=
> 56RJxsvWn+zbh_RCExq7LeMPvxQCKahy2oEUhLBo0xPFNHQ at mail.gmail.com>
> Content-Type: text/plain; charset="utf-8"
>
> I've always thought triage is more than labeling an issue. If it's a bug, I
> consider triage as confirming it (a) exists on main (even if the user says
> they did) and (b) confirming it is indeed undesired behavior. If it's
> reported as a regression then in addition I think it should be confirmed it
> does exist on the previous version of pandas.
>
> All of this can be time intensive. However, I can quickly go through the
> recently reported issues and appropriately label them so that they are more
> visible to other developers who specialize in those areas of the code. When
> I do this but not the above steps, I leave the Needs Triage on.
>
> I'm interested to hear thoughts and feedback here, and if there is a more
> desirable way.
>
> Best,
> Richard
>
>
>
> On Wed, May 3, 2023, 06:07 Dea Mar?a <deamarialeon at gmail.com> wrote:
>
> > I just meant that in many cases people forget to remove the ?needs
> triage?
> > label after having done the triage.
> >
> >
> >
> > On Wed, May 3, 2023 at 11:43?AM Marc Garcia <garcia.marc at gmail.com>
> wrote:
> >
> >> Not sure if other set the label manually, but I assumed in most cases
> the
> >> label is applied automatically by our issue templates. Regular users
> can't
> >> set labels themselves afaik. And if I set labels manually, I consider I
> >> already did the triage so I don't set that label.
> >>
> >> Thanks for letting us know, this is helpful, if you still find the issue
> >> after the message, it may be worth discussing the workflow with the
> exact
> >> person (in the issue log you should be able to see who changes the
> labels.
> >>
> >>
> >>
> >> On Wed, May 3, 2023, 10:21 Dea Mar?a <deamarialeon at gmail.com> wrote:
> >>
> >>> Dear All,
> >>>
> >>>
> >>> If you are helping with triage, it would be nice if you could also
> >>> remove the ?needs triage? label after labelling the issue.
> >>>
> >>>
> >>> Sometimes the person who reported the issue also sets the labels. So,
> it
> >>> is not obvious if the labeling was done by a core-dev or not until I
> open
> >>> the issue.
> >>>
> >>> Sure, it only takes a few seconds to find that my ?extremely important?
> >>> help ;-) is not needed. But newcomers? time is also valuable.
> >>>
> >>>
> >>> Please help us help you. :)
> >>>
> >>>
> >>> Thanks,
> >>>
> >>> Dea
> >>> _______________________________________________
> >>> Pandas-dev mailing list
> >>> Pandas-dev at python.org
> >>> https://mail.python.org/mailman/listinfo/pandas-dev
> >>>
> >> _______________________________________________
> > Pandas-dev mailing list
> > Pandas-dev at python.org
> > https://mail.python.org/mailman/listinfo/pandas-dev
> >
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <
> https://mail.python.org/pipermail/pandas-dev/attachments/20230503/7da68893/attachment-0001.html
> >
>
> ------------------------------
>
> Message: 2
> Date: Wed, 3 May 2023 14:19:14 +0100
> From: Simon Hawkins <simonjayhawkins at gmail.com>
> To: Richard Shadrach <rhshadrach at gmail.com>
> Cc: Dea Mar?a <deamarialeon at gmail.com>, pandas-dev
>         <pandas-dev at python.org>
> Subject: Re: [Pandas-dev] Triage
> Message-ID:
>         <CAFs9qGsdidqX2C_mwKkyBaS6A3K8qp=
> DCTyF0p3C+AQV2m9oXQ at mail.gmail.com>
> Content-Type: text/plain; charset="utf-8"
>
> Agree with Richard.
>
> Even if not reported as a regression by the user, I often use to check the
> behaviour of bugs reported on previous versions to double check (Once the
> code sample is pasted into a notebook does not take long to re-run on
> previous versions once setup)
>
> If found to be a regression, I feel a bisect to isolate the commit is a
> worthwhile part of the triage process (and cc the author)
>
> For most issues, IMHO one should only remove the needs triage label if one
> is knowledgeable enough to add a value add comment. Thanking the user,
> clarifying the issue and suggesting an action to allow progress on the
> issue for other readers. (If one is not knowledgeable enough about the
> topic to do this, probably best to leave the needs triage to someone more
> knowledgeable and not add noise.)
>
> I think the actions of just adding additional labels to help others find
> issues should not be considered triage but is also a very
> worthwhile maintenance task.
>
> My two cents
> Simon
>
> On Wed, 3 May 2023 at 13:05, Richard Shadrach <rhshadrach at gmail.com>
> wrote:
>
> > I've always thought triage is more than labeling an issue. If it's a bug,
> > I consider triage as confirming it (a) exists on main (even if the user
> > says they did) and (b) confirming it is indeed undesired behavior. If
> it's
> > reported as a regression then in addition I think it should be confirmed
> it
> > does exist on the previous version of pandas.
> >
> > All of this can be time intensive. However, I can quickly go through the
> > recently reported issues and appropriately label them so that they are
> more
> > visible to other developers who specialize in those areas of the code.
> When
> > I do this but not the above steps, I leave the Needs Triage on.
> >
> > I'm interested to hear thoughts and feedback here, and if there is a more
> > desirable way.
> >
> > Best,
> > Richard
> >
> >
> >
> > On Wed, May 3, 2023, 06:07 Dea Mar?a <deamarialeon at gmail.com> wrote:
> >
> >> I just meant that in many cases people forget to remove the ?needs
> >> triage? label after having done the triage.
> >>
> >>
> >>
> >> On Wed, May 3, 2023 at 11:43?AM Marc Garcia <garcia.marc at gmail.com>
> >> wrote:
> >>
> >>> Not sure if other set the label manually, but I assumed in most cases
> >>> the label is applied automatically by our issue templates. Regular
> users
> >>> can't set labels themselves afaik. And if I set labels manually, I
> consider
> >>> I already did the triage so I don't set that label.
> >>>
> >>> Thanks for letting us know, this is helpful, if you still find the
> issue
> >>> after the message, it may be worth discussing the workflow with the
> exact
> >>> person (in the issue log you should be able to see who changes the
> labels.
> >>>
> >>>
> >>>
> >>> On Wed, May 3, 2023, 10:21 Dea Mar?a <deamarialeon at gmail.com> wrote:
> >>>
> >>>> Dear All,
> >>>>
> >>>>
> >>>> If you are helping with triage, it would be nice if you could also
> >>>> remove the ?needs triage? label after labelling the issue.
> >>>>
> >>>>
> >>>> Sometimes the person who reported the issue also sets the labels. So,
> >>>> it is not obvious if the labeling was done by a core-dev or not until
> I
> >>>> open the issue.
> >>>>
> >>>> Sure, it only takes a few seconds to find that my ?extremely
> important?
> >>>> help ;-) is not needed. But newcomers? time is also valuable.
> >>>>
> >>>>
> >>>> Please help us help you. :)
> >>>>
> >>>>
> >>>> Thanks,
> >>>>
> >>>> Dea
> >>>> _______________________________________________
> >>>> Pandas-dev mailing list
> >>>> Pandas-dev at python.org
> >>>> https://mail.python.org/mailman/listinfo/pandas-dev
> >>>>
> >>> _______________________________________________
> >> Pandas-dev mailing list
> >> Pandas-dev at python.org
> >> https://mail.python.org/mailman/listinfo/pandas-dev
> >>
> > _______________________________________________
> > Pandas-dev mailing list
> > Pandas-dev at python.org
> > https://mail.python.org/mailman/listinfo/pandas-dev
> >
> -------------- next part --------------
> An HTML attachment was scrubbed...
> URL: <
> https://mail.python.org/pipermail/pandas-dev/attachments/20230503/fdb6cd38/attachment.html
> >
>
> ------------------------------
>
> Subject: Digest Footer
>
> _______________________________________________
> Pandas-dev mailing list
> Pandas-dev at python.org
> https://mail.python.org/mailman/listinfo/pandas-dev
>
>
> ------------------------------
>
> End of Pandas-dev Digest, Vol 120, Issue 2
> ******************************************
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.python.org/pipermail/pandas-dev/attachments/20230503/6590b0c5/attachment-0001.html>