[Inpycon] Is PyCon India "really open"?

[vijay kumar]

On Sat, Jan 13, 2018 at 12:38 AM, Peeyush Aggarwal <
peeyushaggarwal94 at gmail.com> wrote:

>
>
> On 13-Jan-2018 12:34 AM, "vijay kumar" <vnbang2003 at gmail.com> wrote:
>
>
>
> On Sat, Jan 13, 2018 at 12:22 AM, Peeyush Aggarwal <
> peeyushaggarwal94 at gmail.com> wrote:
>
>>
>>
>> On Sat, Jan 13, 2018 at 12:18 AM, vijay kumar <vnbang2003 at gmail.com>
>> wrote:
>>
>>>
>>>
>>> On Sat, Jan 13, 2018 at 12:14 AM, Sanyam Khurana <
>>> sanyam.khurana01 at gmail.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> On Fri, Jan 12, 2018 at 11:51 PM, vijay kumar <vnbang2003 at gmail.com>
>>>> wrote:
>>>> > The point is you were not involved in any discussion and you were
>>>> reviewing
>>>> > things without knowing anything about it .
>>>>
>>>> His review *by no means* is final review. It only helps the reviewer
>>>> with merge rights to merge the PR. And the reviewer who actually
>>>> merges the PR takes the responsibility of handling any
>>>> conflicts/changes etc. This is the case in *every*  open-source
>>>> project that I know of/ have contributed to.
>>>>
>>>> I will just state the definition of Open Source from Wikipedia [0]:
>>>>
>>>> "Open-source software (OSS) is computer software with its source code
>>>> made available with a license in which the copyright holder provides
>>>> the rights to study, change, and distribute the software to anyone and
>>>> for any purpose. Open-source software may be developed in a
>>>> collaborative public manner. According to scientists who studied it,
>>>> open-source software is a prominent example of open collaboration."
>>>>
>>>> > Why act like you are reviewer when you were not involved ?
>>>>
>>>> Open Source means potentially *anyone* in the world can tell you that
>>>> your code is wrong. They can review it. They are FREE to comment on it
>>>> about what they think is wrong or right with it. People appreciate
>>>> help in FOSS, they don't discourage it.
>>>>
>>>
>>> Do you approve pull request without having knowledge?
>>>
>>
>> Even if the chap was wrong on his part, you could have handled it better.
>>
>> Saying, "Thanks for the approval, We will merge it once its approved by
>> the concerned reviewer or XYZ"  rather than saying "Who are you?"
>>
> Read complete context  I have *requested* him to stop reviewing it.
>
>
> Requesting by revoking his rights?
>
How did he approve PR if right were revoked?


-- 
Thanks,
Vijay
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/inpycon/attachments/20180113/db34bd83/attachment.html>