[XML-SIG] Re: [XML-checkins]xml setup.py,1.69,1.70

[Fred L. Drake, Jr.]

Martin v. Loewis writes:
 > By the same rationale, you could remove all the other defines from
 > setup.py as well. It's not that VERSION is not needed anymore -

I've now removed XML_NS, XML_DTD, and XML_CONTEXT_BYTES.  The code to
determine byteorder is simpler since we require Python 2.0 or newer.

 > instead, PACKAGE_VERSION is now defined in expat_config.h. This ought
 > to be a generated file, but isn't.

I'm guessing PACKAGE_VERSION came from the GNU autosplat tools; it's
not used in Expat, and there's nothing in Expat's configure.in that
would cause it to be added as far as I can tell, though I'm no
autosplat expert.

 > We'll see how this works out: In principle, shipping a preconfigured
 > expat_config.h is evil, since it says things like HAVE_BCOPY,
 > HAVE_DLFCN_H, ... which may not be true for the target system.

I agree in principle, but don't have an alternate solution handy.  You
already have a bug report filed on this for Expat, which seems the
appropriate place for this to be dealt with.


  -Fred

-- 
Fred L. Drake, Jr.  <fdrake at acm.org>
PythonLabs at Zope Corporation