[XML-SIG] Minidom bugs/questions

[Martin v. Loewis]

> Are there also PyXML versions?  Someone should update them too then.

At the moment, the Python versions are a couple of revisions
ahead. I'll add the recently-discussed factory finder for DOM
implementations to xml.dom.__init__, and merge all that into PyXML
afterwards.

> I'll leave it to Martin to add code to raise hell when
> createDocument() is passed an empty qualified name, and also to change
> pulldom to do the right thing when it in fact passes a non-null
> qualified name

Done.

> The code in startDocument() looks like it would insert two document
> elements if self._locator is set and its getPublicId() returns a
> non-null qualified name.  I don't know how to fix that, or how
> common this is.

I think this code was completely bogus. The author apparently thought
of creating DocumentTypes, in which case publicId and systemId would
be required. However, the SAX locator does not provide that
information (atleast not for the DTD; rather for the document itself),
nor were we in the process of creating document types. 

It seems that the processing of the doctype argument is also
incorrect: It should *not* create one given the qualifiedName, atleast
I can't find any indication that it should. It MUST set the
ownerDocument, though, which it doesn't. I'm not sure whether the
doctype needs to appear in the childNodes of the Document, can anybody
clarify this?

Regards,
Martin