[Spambayes] Problem with KMail and sb_bnfilter

[Peter Barker]

Thanks Toby,

The patch fixed the duplication of From lines. (I applied the patch to 
sb_bnserver distributed with spambayes-1.1a2, so the patched line number was 
different.)

The original version definitely inserted another From line, not From:. For 
example, the first 2 lines of a message:

From brabq at netvigator.com Fri Jul  1 04:06:06 2005
Return-Path: <pvqjeeljvn at netzero.net>

became

From brabq at netvigator.com Fri Jul  1 04:06:06 2005
From nobody Sat May 27 08:08:45 2006
Return-Path: <pvqjeeljvn at netzero.net>

after using the original sb_bnserver.py. The From: line remained unchanged 
further down in the headers.

I am not sure that the KMail problem was caused by the extra From line, as I 
was experimenting with suspend, and the problem occurred after a computer 
crash. KMail displayed a message with no contents, just the subject, sender 
etc. I removed the second From line with another editor, and KMail displayed 
the message properly, after re-indexing the folder. So it may have been an 
index error caused by the crash. However I don't think it is a good idea to 
have a second incorrect From line in a message anyway.

Regards,
Peter Barker

On Friday 26 May 2006 23:28, Toby Dickenson wrote:
> On Friday 26 May 2006 08:05, Peter Barker wrote:
> > I simply
> > replaced piping the messsages through sb_filter.py with piping through
> > sb_bnfilter.py.
>
> ....
>
> > Is this how sb_bnfilter is supposed to be used
>
> Yes
>
> > However this always inserted a second From (not From:)
>
> Interesting.
>
> It looks like sb_filter will preserve any From line, but not insert one if
> it does not already exist. sb_bnfilter always includes one in its output.
>
> I cant see why sb_bnfilter would insert a *second* From line. Or are you
> counting the "From:" header line as the second?
>
> > sometimes confused KMail.
>
> What confusion are you seeing? (I have been using sb_bnfilter with kmail
> since it was first developed without problem)
>
> > and does this indicate a problem with sb_bnfilter or with KMail?
>
> Try the attached patch to make sb_bnfilter behave the same as sb_filter.