[SciPy-Dev] scipy stats: doc strings of discrete distributions

[Ralf Gommers]

On Tue, May 8, 2012 at 11:47 PM, nicky van foreest <vanforeest at gmail.com>wrote:

> Hi,
>
> I just committed some changes and issues a pull request. I don't know
> why but I cannot notify anybody about my changes. At least, there is
> no list of people (which should be there according to the github docs
> that I am reading) that I can notify. I'll try to see tomorrow how to
> resolve this.
>

Can you point me to the github doc that was unclear?


> I made the pull request as user nokfi, in case this helps finding the
> commits.
>
> You did everything correctly and your PR looks good (didn't check in
detail yet). Committers get automatically notified for PRs, and your email
notified the scipy-dev list as requested. In the howto-contribute document
it says:

"When you send the PR for a new feature, be sure to also mention this on
the scipy-dev mailing list.  This can prompt interested people to help
review your PR."

I'll add to that that committers automatically get notified already.

Cheers,
Ralf


> Once all this works, I'll try my hands on some more serious things,
> like solving for the ppf() Josef and I have been discussing
> previously.
>
> NIcky
>
> On 8 May 2012 22:35,  <josef.pktd at gmail.com> wrote:
> > On Tue, May 8, 2012 at 4:18 PM, nicky van foreest <vanforeest at gmail.com>
> wrote:
> >> Hopefully you don't mind that I try to keep topics separated by
> >> sending separated mails.
> >>
> >> I noticed that the implementation of the doc strings differ for
> >> rv_continuous and rv_discrete.  rv_continuous implementations look
> >> like
> >>
> >> class expon_gen(....):
> >>   """
> >>   docs...
> >>   """
> >>   def _rvs(...)
> >>
> >> expon = expon_gen(....)
> >>
> >>
> >> On the other hand, binom looks like
> >>
> >> class binom_gen(rv_discrete):
> >>    def _rvs(self, n, p):
> >>
> >> binom = binom_gen(name='binom',shapes="n, p",extradoc="""
> >>
> >> Binomial distribution
> >> """
> >>
> >> Any objections against moving the extra doc and make the discrete
> >> distributions look more like the continuous ones?
> >
> > No objections, they should also be converted to distribution specific
> > docstring templates as Ralf did for the continuous distributions.
> >
> > Josef
> >
> >> _______________________________________________
> >> SciPy-Dev mailing list
> >> SciPy-Dev at scipy.org
> >> http://mail.scipy.org/mailman/listinfo/scipy-dev
> > _______________________________________________
> > SciPy-Dev mailing list
> > SciPy-Dev at scipy.org
> > http://mail.scipy.org/mailman/listinfo/scipy-dev
> _______________________________________________
> SciPy-Dev mailing list
> SciPy-Dev at scipy.org
> http://mail.scipy.org/mailman/listinfo/scipy-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scipy-dev/attachments/20120509/f387eb89/attachment.html>