code review

[MRAB]

On 29/06/2012 20:41, Alister wrote:
> On Fri, 29 Jun 2012 09:03:22 -0600, Littlefield, Tyler wrote:
>
>> On 6/29/2012 1:31 AM, Steven D'Aprano wrote:
>>> On Thu, 28 Jun 2012 20:58:15 -0700, alex23 wrote:
>>>
>>>> On Jun 29, 12:57 pm, "Littlefield, Tyler" <ty... at tysdomain.com> wrote:
>>>>> I was curious if someone wouldn't mind poking at some code. The
>>>>> project page is at:http://code.google.com/p/pymud Any information is
>>>>> greatly appreciated.
>>>> I couldn't find any actual code at that site, the git repository is
>>>> currently empty.
>>
>> OOPS, sorry. Apparently I'm not as good with git as I thought.
>> Everything's in the repo now.
>
> I am no expert but from what have picked up so far
>
> from x import
>
>   is frowned upon in most cases
>
I think you mean:

     from x import *

> also this section in main strikes me as a bit odd and convoluted
>
>      w = world()
>      serv = server(client)
>      w.server = serv
>      serv.world = w
>
> I think you are cross referencing classes & would be better to
> investigate inheritance.
>
>