[Python-Dev] [Python-checkins] cpython (2.7): Issue #13156: revert changeset f6feed6ec3f9, which was only relevant for native

Terry Reedy tjreedy at udel.edu
Sat Oct 15 22:10:02 CEST 2011


On 10/15/2011 7:47 AM, "Martin v. Löwis" wrote:
>>> -- Issue #10517: After fork(), reinitialize the TLS used by the
>>> PyGILState_* - APIs, to avoid a crash with the pthread implementation in
>>> RHEL 5. Patch - by Charles-François Natali.
>>
>> You should restore this NEWS entry and add a new one to say that the
>> patch has
>> been reverted.
>
> This may be a done deal, but: no. If a patch is reverted, the NEWS entry
> that got in with it gets out again on reversal. The NEWS file
> is for users of the release; there is no point telling them that a
> change was made first, and than got undone.

I was going to say the same thing, but ...

If a change is released in x.y.z and reverted for release x.y.(z+k), 
then I think both notices should be present in their respective sections.

I checked the date on the original patch and it was before 3.2.1, so 
perhaps it *was* released.

-- 
Terry Jan Reedy




More information about the Python-Dev mailing list