[Python-Dev] New Unicode warnings

[Guido van Rossum]

> tim peters wrote:
> 
> > There are 3 functions now where the prototypes in unicodeobject.h don't
> > match the definitions in unicodeobject.c.  Like, in .h,
> > 
> > extern DL_IMPORT(Py_UNICODE) _PyUnicode_ToTitlecase(
> >     register const Py_UNICODE ch /* Unicode character */
> >     );
> >
> > but in .c:
> > 
> > Py_UNICODE _PyUnicode_ToTitlecase(register Py_UNICODE ch)
> 
> what's that "register" doing in a prototype?

Enjoying a day off?

> any reason we cannot just change the signature(s) to
> 
>     Py_UNICODE _PyUnicode_ToTitlecase(Py_UNICODE ch)
> 
> to make it look more like contemporary C code?
> 
> </F>

I cannot see how either register or const are going to make any
difference in the prototype given that Py_UNICODE is a scalar type, so
please just do it.

--Guido van Rossum (home page: http://www.python.org/~guido/)