[Python-checkins] [3.6] bpo-33759: Fix test.test_xmlrpc.ServerProxyTestCase. (GH-7362) (GH-7375)

Ned Deily webhook-mailer at python.org
Sun Jun 3 23:36:18 EDT 2018


https://github.com/python/cpython/commit/2e601c54d9d5f03f1fe1f7b4a1f2cb8e843fdeae
commit: 2e601c54d9d5f03f1fe1f7b4a1f2cb8e843fdeae
branch: 3.6
author: Serhiy Storchaka <storchaka at gmail.com>
committer: Ned Deily <nad at python.org>
date: 2018-06-03T23:36:15-04:00
summary:

[3.6] bpo-33759: Fix test.test_xmlrpc.ServerProxyTestCase. (GH-7362) (GH-7375)

It depended on a global variable set by other tests..
(cherry picked from commit 7cfd8c6a1b53a7dbdea14b6f414f2629dcd130a2)

Co-authored-by: Serhiy Storchaka <storchaka at gmail.com>

files:
M Lib/test/test_xmlrpc.py

diff --git a/Lib/test/test_xmlrpc.py b/Lib/test/test_xmlrpc.py
index f9bf304010e1..07f7ba0f00b5 100644
--- a/Lib/test/test_xmlrpc.py
+++ b/Lib/test/test_xmlrpc.py
@@ -1179,13 +1179,9 @@ def test_gzip_decode_limit(self):
 class ServerProxyTestCase(unittest.TestCase):
     def setUp(self):
         unittest.TestCase.setUp(self)
-        if threading:
-            self.url = URL
-        else:
-            # Without threading, http_server() and http_multi_server() will not
-            # be executed and URL is still equal to None. 'http://' is a just
-            # enough to choose the scheme (HTTP)
-            self.url = 'http://'
+        # Actual value of the URL doesn't matter if it is a string in
+        # the correct format.
+        self.url = 'http://fake.localhost'
 
     def test_close(self):
         p = xmlrpclib.ServerProxy(self.url)



More information about the Python-checkins mailing list