[Mailman-Developers] Bug in Bouncer.py (was: At least some of my problems...)

[Dan Mick]

Or not.  That was the proverbial pickled scarlet fish.

Here's a fix to Bouncer.py.  I'm divided about the wisdom of including
some keywords and not all.  I suppose I should at least be consistent,
but I know Barry will fix it right anyway.

Index: Bouncer.py
===================================================================
RCS file: /cvsroot/mailman/mailman/Mailman/Bouncer.py,v
retrieving revision 2.23
diff -u -r2.23 Bouncer.py
--- Bouncer.py  11 Feb 2002 21:05:10 -0000      2.23
+++ Bouncer.py  27 Feb 2002 04:05:51 -0000
@@ -165,8 +165,8 @@
              }, mlist=self)
         subject = _('Bounce action notification')
         umsg = Message.UserNotification(self.GetOwnerEmail(),
-                                        siteowner, subject,
-                                        self.preferred_language)
+                                        siteowner, subject, text=None,
+                                        lang=self.preferred_language)
         umsg.attach(MIMEText(text))
         if isinstance(msg, StringType):
             umsg.attach(MIMEText(msg))
@@ -222,8 +222,8 @@
             notice = _(e.notice())
         # Currently we always craft bounces as MIME messages.
         bmsg = Message.UserNotification(msg.get_sender(),
-                                        self.GetOwnerEmail(),
-                                        subject, self.preferred_language)
+                                        self.GetOwnerEmail(), subject, 
+                                       text=None, lang=self.preferred_language)
         bmsg['Content-Type'] = 'multipart/mixed'
         bmsg['MIME-Version'] = '1.0'
         txt = MIMEText(notice,

All Rejected messages and "bounce-disable" messages were getting
corrupted.

> ....with messages that get corrupted in an I18N-ish way, are due
> to the fact that I'd written a Handler module to reject messages
> held for ImplicitDestination reasons (because I was tired of them).
> 
> Um...but I didn't I18N-ize it.
> 
> Oops.
> 
> Sorry Ben, and thanks for the help.  :)
> 
> 
> _______________________________________________
> Mailman-Developers mailing list
> Mailman-Developers@python.org
> http://mail.python.org/mailman/listinfo/mailman-developers