[Mailman-Developers] [PATCH] Fix endless prefix adding with q-p/base64 Subject lines

Mikhail Zabaluev mhz@alt-linux.org
Mon, 8 Apr 2002 12:42:41 +0400


Hello Ben,

On Mon, Apr 08, 2002 at 01:51:00AM +0900, Ben Gertzfield wrote:
>
> On Monday, April 8, 2002, at 01:05 , Fil wrote:
> 
> >This is a two-prefix subject line (taken from the mailman .mbox file, in
> >order to be sure)
> >
> >    Subject: [Spip] =?iso-8859-1?Q?Re:_=5BSpip=5D_exclusion_mot_cl=E9s?=
> >
> 
> Fil,
> 
> I just checked CVS and you are indeed right.  I thought I had sent this 
> patch in ages ago, but I can't find it in the archives.
> 
> Barry, this patch to CookHeaders.py fixes this issue of endless prefix 
> string adding if the Subject line gets encoded, by decoding the Subject 
> line before searching for the prefix.  It encodes the new prefix if 
> needed as a separate chunk in the new Subject header.  This will allow 
> for Japanese, French, whatever prefix strings.
> 
> I really apologize, I thought it was sent in and applied many moons 
> ago.  I need a better brain. :)
> 
> I'm attaching the patch, but this is the crazy Mac OS X Mail.app, so who 
> knows if it will be readable or not.  In case it's not, here is a URL 
> for the patch:
> 
> http://people.debian.org/~che/mailman/patches/cook-headers.patch

Finally it's getting fixed. Still though, there is a possibility of
the prefix being scattered between encoded/ASCII chunks; this code
will not find it then. I haven't seen yet if this case is realistic or
not.
You can take a look at two more patches that address this problem, at
SourceForge:

http://sourceforge.net/tracker/index.php?func=detail&aid=498766&group_id=103&atid=300103

http://sourceforge.net/tracker/index.php?func=detail&aid=528031&group_id=103&atid=300103

-- 
Stay tuned,
  MhZ                                     JID: mookid@jabber.org
___________
Five is a sufficiently close approximation to infinity.
		-- Robert Firth

"One, two, five."
		-- Monty Python and the Holy Grail