[Mailman-Developers] Big checkins a'comin'!

[Barry A. Warsaw]

>>>>> "RJ" == Ron Jarrell <jarrell@vt.edu> writes:

    RJ> And in other news, here in early adopters hell :-)...

Mwah, ha, ha!

    RJ> Ok, figuring, what the hell, it couldn't hurt, I copied all
    RJ> the .txt and .html files from templates into a new
    RJ> templates/en directory.  This at least got me the forms back
    RJ> (although listinfo still won't render %(hostname))

Hmm, it works for me, although I haven't done a fresh install yet.

    RJ> Ah, I see why.  In CheckSiteAdminPassword we do a

    RJ> challenge = fp.read()[-1]

    RJ> The comment says this strips off the newline.  Now, my python
    RJ> is week, but doesn't that actually return *just* the newline.
    RJ> So naturally the hexdigest of the original password doesn't
    RJ> match the hexdigest of a \012...

    | So, shouldn't that be 
    | challenge = fp.read()[0:-1]

Darn, good catch.  That should be "fp.read()[:-1]" -- you don't need
the start index if it's 0.  I just checked in a patch.

-Barry