[Mailman-Developers] Re: Approval bug in 2.0b3 (fixed)

[Ron Jarrell]

Ok, I went digging through the code (I've really got to learn more
Python).  It looks like the def for HanderAPI.DeliverToList got changed,
but the instance where ListAdmin.py uses it didn't.  Or ListAdmin.py
got changed, but HandlerAPI hasn't caught up?  Dunno.  ListAdmin
assumes the third arg is a newdata= format, but the API just shows
the third arg as msgdata.  So I made this patch, and suddenly all the
admindb approval stuff is working again:

Index: ListAdmin.py
===================================================================
RCS file: /cvsroot/mailman/mailman/Mailman/ListAdmin.py,v
retrieving revision 1.32
diff -c -r1.32 ListAdmin.py
*** ListAdmin.py        2000/05/22 21:37:05     1.32
--- ListAdmin.py        2000/05/30 21:23:38
***************
*** 180,186 ****
              msg = Message.Message(fp)
              msgdata['approved'] = 1
              # ignore return value
!             HandlerAPI.DeliverToList(self, msg, newdata=msgdata)
          elif value == 1:
              # Rejected
              rejection = 'Refused'
--- 180,186 ----
              msg = Message.Message(fp)
              msgdata['approved'] = 1
              # ignore return value
!             HandlerAPI.DeliverToList(self, msg, msgdata)
          elif value == 1:
              # Rejected
              rejection = 'Refused'