[Mailman-Developers] Re: admin approval and list archive

[Thomas Wouters]

--sdtB3X0nJg68CQEu
Content-Type: text/plain; charset=us-ascii

On Fri, Mar 24, 2000 at 11:57:27PM +0100, Thomas Wouters wrote:

> There seems to be a bug in the pipermail archiving in combination with admin
> aproved messages. The bug is that, in the archive mbox, 'From ' lines will
> be missing from messages which have been passed through admin approval,
> which means that they will be considered part of the previous message or, if
> there is no previous message, that the mbox is invalid and no archive will
> be built.

I've been able to test it properly now... the mailbox.py bug wrt unixfrom is
unrelated (but still a bug, imho) and just this diff (attached again) is
enough to fix Mailman. Since msg.unixfrom is '' if unixfrom isn't set, this
shouldn't break a thing.

Regards,
-- 
Thomas Wouters <thomas@xs4all.net>

Hi! I'm a .signature virus! copy me into your .signature file to help me spread!

--sdtB3X0nJg68CQEu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=cvsdiff

Index: Mailman/ListAdmin.py
===================================================================
RCS file: /projects/cvsroot/mailman/Mailman/ListAdmin.py,v
retrieving revision 1.28
diff -u -r1.28 ListAdmin.py
--- ListAdmin.py	2000/03/21 06:24:59	1.28
+++ ListAdmin.py	2000/03/24 22:51:54
@@ -139,7 +145,7 @@
         omask = os.umask(002)
         try:
             fp = open(os.path.join(mm_cfg.DATA_DIR, filename), 'w')
-            fp.write(str(msg))
+            fp.write(msg.unixfrom + str(msg))
             fp.close()
         finally:
             os.umask(omask)

--sdtB3X0nJg68CQEu--