[Mailman-Developers] Posting bug

[Barry A. Warsaw]

>>>>> "BN" == Balazs Nagy <julian7@kva.hu> writes:

    BN> Three days ago I downloaded the latest CVS snapshot and I
    BN> applied my patches to it.  Now my users reported that their
    BN> letters didn't posted to the list.

    BN> I found that there's an error in MailList.py (I think).  These
    BN> fast fixes comes from experience and not from evidence :->

I just noticed this one myself today!  Here's a better patch, IMO.

-Barry

-------------------- snip snip --------------------
Index: MailList.py
===================================================================
RCS file: /projects/cvsroot/mailman/Mailman/MailList.py,v
retrieving revision 1.109
diff -c -r1.109 MailList.py
*** MailList.py	1999/01/13 23:55:23	1.109
--- MailList.py	1999/01/24 19:30:29
***************
*** 1138,1146 ****
  		ack_post = 1
  	# Deliver the mail.
  	members = self.GetDeliveryMembers()
  	if dont_send_to_sender:
              try:
!                 recipients.remove(members)
              #
              # sender not in list (case sensitive username problem?)
              #
--- 1138,1150 ----
  		ack_post = 1
  	# Deliver the mail.
  	members = self.GetDeliveryMembers()
+         recipients = []
+         for m in members:
+             if not self.GetUserOption(m, mm_cfg.DisableDelivery):
+                 recipients.append(m)
  	if dont_send_to_sender:
              try:
!                 recipients.remove(sender)
              #
              # sender not in list (case sensitive username problem?)
              #
***************
*** 1149,1158 ****
                              "couldn't remove %s from recipient list: %s",
                              sender,
                              str(members))
-         recipients = []
-         for m in members:
-             if not self.GetUserOption(m, mm_cfg.DisableDelivery):
-                 recipients.append(m)
          self.LogMsg("post", "post to %s from %s size=%d",
                      self._internal_name, msg.GetSender(), len(msg.body))
          
--- 1153,1158 ----