[Mailman-Developers] Little bug(?) in admindb

[Balazs Nagy]

On Fri, 8 Jan 1999, Barry A. Warsaw wrote:

> >>>>> "BN" == Balazs Nagy <julian7@kva.hu> writes:
> 
>     BN> I got four pendings to an email list, but when I wanted to
>     BN> submit my changes, it said that there's an error in line #196.
>     BN> This is a for loop with form.keys() as k, but it cannot
>     BN> interpret form[k].value.
> 
> Can you please send a traceback?  I don't know what kind of error
> you're getting.  Is it an AttributeError or something else?

I didn't have a mouse but a simple console screen with lynx.  Here's my new
test:

With one pending: OK

With two or more pendings:

Traceback (innermost last):
  File "/home/mailman/scripts/driver", line 102, in run_main
    main()
  File "../Mailman/Cgi/admindb.py", line 124, in main
    HandleRequests(doc)
  File "../Mailman/Cgi/admindb.py", line 196, in HandleRequests
    v = int(form[k].value)
AttributeError: value

>     BN> I have no time because I want to finish my cgi extension and
>     BN> MTU patches but for the short-time fix I got out ValueError
>     BN> from the next except line.

Just now Iam rewriting my old patches, but my temp fix is
--- admindb.py.orig     Fri Jan  8 09:13:35 1999
+++ admindb.py  Fri Jan  8 09:13:43 1999
@@ -195,7 +195,7 @@
         try:
             v = int(form[k].value)
             request_id = int(k)
-        except ValueError:
+        except:
             continue
        try:
            request = list.GetRequest(request_id)

> Also, please submit patches against the CVS tree if possible,
> otherwise definitely against 1.0b7.  And if you're looking to get
> these patches into 1.0, *please hurry*!  ;-)

Of course ;) I'll send it today (until 1500CET).
-- 
   Linux Supporting Center -- Red Hat Qmail packages -- http://lsc.kva.hu
      PGP 0x1DE3631D / A8 B4 92 EE 1F 55 27 C8  86 64 9C 42 41 A4 BD B8
                         Don't spell GLIB backwards!