[Mailman-Developers] Upgrade from 1.0b4 -> 1.0b7 fails

Barry A. Warsaw bwarsaw@cnri.reston.va.us (Barry A. Warsaw)
Wed, 6 Jan 1999 18:09:28 -0500 (EST)


>>>>> "WK" == Wayne Knowles <w.knowles@niwa.cri.nz> writes:

    WK> Did I install 1.0b4 incorrectly, or does the update script
    WK> need to be fixed to work around the problem?

You did everything correctly.  It is a problem with the
Mailman/Utils.py file.  Attached is a patch that should fix the
problem.

    WK> BTW - The known problem building under FreeBSD using BSD Make
    WK> appears to be fixed (have tested on FreeSBD 2.2.5 and
    WK> 3.0-current).  I no longer need GNU Make or hack the Makefile
    WK> by hand.

Cool!  Thanks for the feedback -- I can only test with Solaris make
and GNU make, so I'm glad my changes fixed the problem.

-Barry

Index: Utils.py
===================================================================
RCS file: /projects/cvsroot/mailman/Mailman/Utils.py,v
retrieving revision 1.58
diff -c -r1.58 Utils.py
*** Utils.py	1999/01/05 23:03:43	1.58
--- Utils.py	1999/01/06 23:05:03
***************
*** 506,515 ****
      return got
  
  
! def chunkify(members, chunksize=mm_cfg.DEFAULT_ADMIN_MEMBER_CHUNKSIZE):
       """
       return a list of lists of members
       """
       members.sort()
       res = []
       while 1:
--- 506,517 ----
      return got
  
  
! def chunkify(members, chunksize=None):
       """
       return a list of lists of members
       """
+      if chunksize is None:
+          chunksize = mm_cfg.DEFAULT_ADMIN_MEMBER_CHUNKSIZE
       members.sort()
       res = []
       while 1: