[Tutor] Code Review?

[Mark Lawrence]

On 06/08/2012 14:38, Ramchandra Apte wrote:

[top posting fixed]

> On 6 August 2012 18:59, Brian Carpio <bcarpio at thetek.net> wrote:
>
>> Hi,
>>
>> Hopefully I am allowed to ask this here. I am pretty new to python I've
>> only been writing code for about 6 months now strictly for system
>> administration purposes; however I have now decided to write something
>> "real" that others might benefit from but I am looking for someone to take
>> a look at my code and give me an idea on some areas where I need
>> improvement. I certainly don't expect anyone to rewrite my code but if
>> someone is willing to give it a quick look and tell me things like focus
>> more on XX or you really need to learn YY because its obvious you don't
>> have a clue (lol) those types of comments would be more then welcome.
>>
>> I've ran my code through pylint and am getting a score of 7-9 with all of
>> my scripts, but a program can only tell you so much having a real person
>> point out some of my shortcomings would be amazing. Sometimes you don't
>> know you don't know something until someone tells you "Hey you don't know
>> XX or YY go learn it".
>>
>> https://github.com/bcarpio/mongodb-enc
>>
>> Thanks,
>> Brian
>>
>> _______________________________________________
>> Tutor maillist  -  Tutor at python.org
>> To unsubscribe or change subscription options:
>> http://mail.python.org/mailman/listinfo/tutor
>>
>>
>
> _______________________________________________
> Tutor maillist  -  Tutor at python.org
> To unsubscribe or change subscription options:
> http://mail.python.org/mailman/listinfo/tutor
>
> In scripts/add_node.py GPL Licene should be GPL License
>

Please don't top post, it makes it very difficult to follow threads. 
Thanks.

-- 
Cheers.

Mark Lawrence.