From metatracker at psf.upfronthosting.co.za  Mon Jul 24 04:12:55 2017
From: metatracker at psf.upfronthosting.co.za (Nick Coghlan)
Date: Mon, 24 Jul 2017 08:12:55 +0000
Subject: [Tracker-discuss] [issue635] Information on meta-tracker server
 migration
Message-ID: <1500883975.73.0.767118106632.issue635@psf.upfronthosting.co.za>


New submission from Nick Coghlan:

I'm unclear on exactly when this server is going to be moving to a different PSF-controlled domain, and https://wiki.python.org/moin/TrackerDevelopment#The_Meta_Tracker doesn't provide any info either.

----------
messages: 3364
nosy: mmangoba, ncoghlan
priority: urgent
status: unread
title: Information on meta-tracker server migration

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue635>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 24 04:23:10 2017
From: metatracker at psf.upfronthosting.co.za (Nick Coghlan)
Date: Mon, 24 Jul 2017 08:23:10 +0000
Subject: [Tracker-discuss] [issue636] 'patch' keyword not being set for
 PR-only issues
Message-ID: <1500884590.33.0.28763709404.issue636@psf.upfronthosting.co.za>


New submission from Nick Coghlan:

Looking at https://bugs.python.org/issue?@template=stats, it seemed to show a truly remarkable decline in the number of open issues with patches post-GitHub migration, but poking around a bit suggests that's due to a bug: the "patch" keyword isn't getting set when a PR is linked to an issue.

That means such issues don't show up in the weekly "Open Issues with Patches" metrics, and also don't show up in the "Issues with patch" sidebar search.

----------
messages: 3365
nosy: maciej.szulik, ncoghlan
priority: bug
status: unread
title: 'patch' keyword not being set for PR-only issues

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue636>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 24 05:50:49 2017
From: metatracker at psf.upfronthosting.co.za (Berker Peksag)
Date: Mon, 24 Jul 2017 09:50:49 +0000
Subject: [Tracker-discuss] [issue636] 'patch' keyword not being set for
 PR-only issues
In-Reply-To: <1500884590.33.0.28763709404.issue636@psf.upfronthosting.co.za>
Message-ID: <1500889849.69.0.345125943848.issue636@psf.upfronthosting.co.za>


Berker Peksag added the comment:

By the way, I can implement this in http://psf.upfronthosting.co.za/roundup/meta/issue615

----------
nosy: +berker.peksag
status: unread -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue636>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 24 06:19:17 2017
From: metatracker at psf.upfronthosting.co.za (Nick Coghlan)
Date: Mon, 24 Jul 2017 10:19:17 +0000
Subject: [Tracker-discuss] [issue636] 'patch' keyword not being set for
 PR-only issues
In-Reply-To: <1500884590.33.0.28763709404.issue636@psf.upfronthosting.co.za>
Message-ID: <1500891557.52.0.1024879043.issue636@psf.upfronthosting.co.za>


Nick Coghlan added the comment:

That makes sense, so I'll close this as a duplicate and add a comment over there.

----------
status: chatting -> resolved
superseder: +Set stage to 'patch review' when a PR is added

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue636>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 24 06:24:04 2017
From: metatracker at psf.upfronthosting.co.za (Nick Coghlan)
Date: Mon, 24 Jul 2017 10:24:04 +0000
Subject: [Tracker-discuss] [issue615] Set stage to 'patch review' when a PR
 is added
In-Reply-To: <1487512232.69.0.355373365979.issue615@psf.upfronthosting.co.za>
Message-ID: <1500891844.71.0.541517833094.issue615@psf.upfronthosting.co.za>


Nick Coghlan added the comment:

Adding a note about http://psf.upfronthosting.co.za/roundup/meta/issue636: the "patch" keyword currently isn't being set for issues that *only* have a linked PR, which is throwing off both the "Open issues with patches" metrics, and the sidebar query for "Issues with patches". The latter isn't too much of a problem (since folks can just browse the open PR list directly on GitHub instead), but the former makes the graph at https://bugs.python.org/issue?@template=stats rather misleading.

Berker suggested fixing that as part of this update rather than as a standalone change, which seems like a good idea to me.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue615>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 24 09:51:05 2017
From: metatracker at psf.upfronthosting.co.za (Berker Peksag)
Date: Mon, 24 Jul 2017 13:51:05 +0000
Subject: [Tracker-discuss] [issue615] Set stage to 'patch review' when a PR
 is added
In-Reply-To: <1487512232.69.0.355373365979.issue615@psf.upfronthosting.co.za>
Message-ID: <1500904265.06.0.90639162251.issue615@psf.upfronthosting.co.za>


Berker Peksag added the comment:

Thanks for the feedback. Here's a patch that updates 'stage' and 'keywords' fields. This patch updates the detector. I'll upload another one for the webhook.

I'll commit it when I get a code review, thanks!

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue615>
_______________________________________________________
-------------- next part --------------
diff --git a/detectors/setresolved.py b/detectors/issuestates.py
rename from detectors/setresolved.py
rename to detectors/issuestates.py
--- a/detectors/setresolved.py
+++ b/detectors/issuestates.py
@@ -1,16 +1,33 @@
 """
-A detector that sets the 'stage' field to 'resolved' when an issue is closed.
+* Sets the 'stage' field to 'resolved' when an issue is closed.
+* Sets the 'stage' field to 'patch review' and adds 'patch' to the 'keywords' field.
 """
 
 
-def setresolved(db, cl, nodeid, newvalues):
+def issuestates(db, cl, nodeid, newvalues):
     status_change = newvalues.get('status')
     status_close = status_change and status_change == db.status.lookup('closed')
 
     if status_close:
         if newvalues.get('stage') is None:
             newvalues['stage'] = db.stage.lookup('resolved')
 
+    is_open = cl.get(nodeid, 'status') == db.status.lookup('open')
+    patch_keyword = db.keyword.lookup('patch')
+    old_keywords = cl.get(nodeid, 'keywords')
+    new_keywords = newvalues.get('keywords', [])
+    old_prs = cl.get(nodeid, 'pull_requests')
+    new_prs = newvalues.get('pull_requests', [])
+    pr_change = len(new_prs) > len(old_prs)
+    needs_change = is_open and pr_change and newvalues.get('stage') != db.stage.lookup('patch review')
+    if needs_change:
+        newvalues['stage'] = db.stage.lookup('patch review')
+        if patch_keyword not in new_keywords and patch_keyword not in old_keywords:
+            set_new_keywords = old_keywords[:]
+            set_new_keywords.extend(new_keywords)
+            set_new_keywords.append(patch_keyword)
+            newvalues['keywords'] = set_new_keywords
+
 
 def init(db):
-    db.issue.audit('set', setresolved)
+    db.issue.audit('set', issuestates)

From metatracker at psf.upfronthosting.co.za  Mon Jul 24 10:18:49 2017
From: metatracker at psf.upfronthosting.co.za (Berker Peksag)
Date: Mon, 24 Jul 2017 14:18:49 +0000
Subject: [Tracker-discuss] [issue615] Set stage to 'patch review' when a PR
 is added
In-Reply-To: <1487512232.69.0.355373365979.issue615@psf.upfronthosting.co.za>
Message-ID: <1500905929.0.0.443857324897.issue615@psf.upfronthosting.co.za>


Berker Peksag added the comment:

Here's the second patch.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue615>
_______________________________________________________
-------------- next part --------------
diff --git a/roundup/github.py b/roundup/github.py
--- a/roundup/github.py
+++ b/roundup/github.py
@@ -195,17 +195,23 @@ class Event(object):
             # create a new link
             if not title:
                 title = ""
             if not status:
                 status = ""
             newpr = self.db.pull_request.create(number=prid,
                 title=title.encode('utf-8'), status=status.encode('utf-8'))
             prs.append(newpr)
-            self.db.issue.set(id, pull_requests=prs)
+            patch_keyword = self.db.keyword.lookup('patch')
+            keywords = self.db.issue.get(id, 'keywords')
+            if patch_keyword not in keywords:
+                keywords.append(patch_keyword)
+            self.db.issue.set(id, pull_requests=prs,
+                              stage=self.db.stage.lookup('patch review'),
+                              keywords=keywords)
             self.db.commit()
 
     def handle_update(self, prid, title, status, issue_ids):
         """
         Helper method for updating GitHub pull request.
         """
         # update handles only title changes, for now
         if not title:

From metatracker at psf.upfronthosting.co.za  Mon Jul 24 12:30:56 2017
From: metatracker at psf.upfronthosting.co.za (Brett C.)
Date: Mon, 24 Jul 2017 16:30:56 +0000
Subject: [Tracker-discuss] [issue635] Information on meta-tracker server
 migration
In-Reply-To: <1500883975.73.0.767118106632.issue635@psf.upfronthosting.co.za>
Message-ID: <1500913856.39.0.0352747527311.issue635@psf.upfronthosting.co.za>


Brett C. added the comment:

It's unclear because there's no specific plan yet. :) There was talk at PyCon US about potentially having Red Hat host it on OpenShift, but I don't know where Maciej ended up with that.

----------
nosy: +brett.cannon, maciej.szulik
status: unread -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue635>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 24 12:34:29 2017
From: metatracker at psf.upfronthosting.co.za (Mark Mangoba)
Date: Mon, 24 Jul 2017 16:34:29 +0000
Subject: [Tracker-discuss] [issue635] Information on meta-tracker server
 migration
In-Reply-To: <1500883975.73.0.767118106632.issue635@psf.upfronthosting.co.za>
Message-ID: <1500914069.6.0.460498579028.issue635@psf.upfronthosting.co.za>


Mark Mangoba added the comment:

We actually have a plan in place to migrate over to OpenShift by October.  Maciej is on vacation but when he gets back, in August we will start the process.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue635>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 24 12:35:00 2017
From: metatracker at psf.upfronthosting.co.za (Mark Mangoba)
Date: Mon, 24 Jul 2017 16:35:00 +0000
Subject: [Tracker-discuss] [issue635] Information on meta-tracker server
 migration
In-Reply-To: <1500883975.73.0.767118106632.issue635@psf.upfronthosting.co.za>
Message-ID: <1500914100.52.0.380510719055.issue635@psf.upfronthosting.co.za>


Mark Mangoba added the comment:

I'll share the timeline when we solidify the process.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue635>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 24 13:22:11 2017
From: metatracker at psf.upfronthosting.co.za (Sorin Sbarnea)
Date: Mon, 24 Jul 2017 17:22:11 +0000
Subject: [Tracker-discuss] [issue635] Information on meta-tracker server
 migration
In-Reply-To: <1500883975.73.0.767118106632.issue635@psf.upfronthosting.co.za>
Message-ID: <1500916931.94.0.885222566651.issue635@psf.upfronthosting.co.za>


Sorin Sbarnea added the comment:

I think that everyone would benefit from just importing this into GitHub. Considering the number of issues this should be easy and would provide a much better visibility and accessibility... not to mention uptime/low-mentainance/performance/...

----------
nosy: +sorin

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue635>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 28 03:51:41 2017
From: metatracker at psf.upfronthosting.co.za (ylb)
Date: Fri, 28 Jul 2017 07:51:41 +0000
Subject: [Tracker-discuss] [issue637] Exception SystemError:
 '..\\..\\Objects\\listobject.c:169: bad argument to internal function'
Message-ID: <1501228301.97.0.232163355124.issue637@psf.upfronthosting.co.za>


New submission from ylb:

I want to update my mongodb in the __del__ method of my object, but when run the code,it show that Exception SystemError: '..\\..\\Objects\\listobject.c:169: bad argument to internal function' in <bound method del_it.__del__ of <__main__.del_it object at 0x0000000003608128>> ignored.
then I using debug mode, it finished without error.it's very odd.

----------
messages: 3375
nosy: ylb
priority: bug
status: unread
title: Exception SystemError: '..\\..\\Objects\\listobject.c:169: bad argument to internal function'

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue637>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 28 03:55:26 2017
From: metatracker at psf.upfronthosting.co.za (ylb)
Date: Fri, 28 Jul 2017 07:55:26 +0000
Subject: [Tracker-discuss] [issue637] Exception SystemError:
 '..\\..\\Objects\\listobject.c:169: bad argument to internal function'
Message-ID: <1501228526.26.0.69774976915.issue637@psf.upfronthosting.co.za>


New submission from ylb:

from pymongo import MongoClient
client = MongoClient('127.0.0.1:27017')['ylb']['ylb']

class del_it(object):
    def __init__(self):
        print 'creat a object', id(self)
        client.update({'id':6253282}, {'$set':{'flag':True}})

    def __del__(self):
        client.update({'id': 6253282}, {'$set': {'flag': False}})
        print '?????', id(self)

if __name__ == "__main__":
    a = del_it()

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue637>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 28 03:57:55 2017
From: metatracker at psf.upfronthosting.co.za (ylb)
Date: Fri, 28 Jul 2017 07:57:55 +0000
Subject: [Tracker-discuss] [issue637] Exception SystemError:
 '..\\..\\Objects\\listobject.c:169: bad argument to internal function'
In-Reply-To: <1501228526.26.0.69774976915.issue637@psf.upfronthosting.co.za>
Message-ID: <1501228675.23.0.889845410631.issue637@psf.upfronthosting.co.za>


ylb added the comment:

when I run this code the error message show, then I used debug mode the problem disappeared. the message like this :
Exception SystemError: '..\\..\\Objects\\listobject.c:169: bad argument to internal function' in <bound method del_it.__del__ of <__main__.del_it object at 0x0000000003468198>> ignored

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue637>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 28 08:32:13 2017
From: metatracker at psf.upfronthosting.co.za (Berker Peksag)
Date: Fri, 28 Jul 2017 12:32:13 +0000
Subject: [Tracker-discuss] [issue637] Exception SystemError:
 '..\\..\\Objects\\listobject.c:169: bad argument to internal function'
In-Reply-To: <1501228526.26.0.69774976915.issue637@psf.upfronthosting.co.za>
Message-ID: <1501245133.97.0.629362785955.issue637@psf.upfronthosting.co.za>


Berker Peksag added the comment:

Thank you for the report, but this is not the correct place to report issues with third-party Python modules.

The exception message suggests that your Python version is 2.7 and it comes from PyList_Size(): https://github.com/python/cpython/blob/c2f7fb61511456c62877592988b31714cb8ba266/Objects/listobject.c#L169

And since I don't get any error when I remove the pymongo parts from your reproducer, I think you should report this to pymongo developers at https://jira.mongodb.org/browse/PYTHON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel

----------
nosy: +berker.peksag
status: chatting -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue637>
_______________________________________________________