From metatracker at psf.upfronthosting.co.za  Sat Jul  2 13:55:29 2011
From: metatracker at psf.upfronthosting.co.za (Vinay Sajip)
Date: Sat, 02 Jul 2011 11:55:29 +0000
Subject: [Tracker-discuss] [issue408] Tracker development setup fails
In-Reply-To: <1309607729.46.0.543451245542.issue408@psf.upfronthosting.co.za>
Message-ID: <1309607729.46.0.543451245542.issue408@psf.upfronthosting.co.za>


New submission from Vinay Sajip <vinay_sajip at yahoo.co.uk>:

I tried to set up an instance of the Python tracker for development, according to the instructions given at

http://wiki.python.org/moin/TrackerDevelopment

I get an error relating to Rietveld setup, despite following all the suggested steps:

(roundup)vinay at eta-natty:~/tools/pytracker/instances/python-dev$ roundup-admin -i `pwd` init
Admin Password: 
       Confirm: 
Traceback (most recent call last):
  File "/home/vinay/.virtualenvs/roundup/bin/roundup-admin", line 3, in <module>
    run()
  File "/home/vinay/.virtualenvs/roundup/lib/python2.7/site-packages/roundup/scripts/roundup_admin.py", line 38, in run
    sys.exit(tool.main())
  File "/home/vinay/.virtualenvs/roundup/lib/python2.7/site-packages/roundup/admin.py", line 1546, in main
    ret = self.run_command(args)
  File "/home/vinay/.virtualenvs/roundup/lib/python2.7/site-packages/roundup/admin.py", line 1424, in run_command
    return self.do_initialise(self.tracker_home, args)
  File "/home/vinay/.virtualenvs/roundup/lib/python2.7/site-packages/roundup/admin.py", line 517, in do_initialise
    tracker.init(password.Password(adminpw))
  File "/home/vinay/.virtualenvs/roundup/lib/python2.7/site-packages/roundup/instance.py", line 199, in init
    'admin_email': self.config['ADMIN_EMAIL']})
  File "/home/vinay/.virtualenvs/roundup/lib/python2.7/site-packages/roundup/instance.py", line 211, in _load_python
    execfile(file, vars)
  File "/home/vinay/tools/pytracker/instances/python-dev/initial_data.py", line 116, in <module>
    user.create(username="admin", password=adminpw, address=admin_email, roles='Admin')
  File "/home/vinay/.virtualenvs/roundup/lib/python2.7/site-packages/roundup/backends/rdbms_common.py", line 1389, in create
    self.fireReactors('create', newid, None)
  File "/home/vinay/.virtualenvs/roundup/lib/python2.7/site-packages/roundup/hyperdb.py", line 1220, in fireReactors
    react(self.db, self, nodeid, oldvalues)
  File "/home/vinay/tools/pytracker/instances/python-dev/detectors/rietveldreactor.py", line 16, in create_django_user
    (nodeid, username, email))
psycopg2.ProgrammingError: relation "auth_user" does not exist
LINE 1: insert into auth_user(id, username, email, password, first_n...
                    ^

(roundup)vinay at eta-natty:~/tools/pytracker/instances/python-dev$ 

I would suggest that one of these approaches should be taken:

1. The configuration is changed so that Rietveld integration does not occur by default, and the documentation is updated to tell those who need it how to do Rietveld integration (as is done for Spambayes)

2. Change the init script to do the relevant Django /Rietveld configuration magic so that users who just want to e.g. hack on some templates for the basic UI (like me in this case :-) don't get side-tracked into some rabbit-hole ...

----------
messages: 2111
nosy: vinay.sajip
priority: bug
status: unread
title: Tracker development setup fails

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue408>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sat Jul 16 21:19:35 2011
From: metatracker at psf.upfronthosting.co.za (Alan Kennedy)
Date: Sat, 16 Jul 2011 19:19:35 +0000
Subject: [Tracker-discuss] [issue409] Spam on jython tracker.
In-Reply-To: <1310843975.4.0.271262889404.issue409@psf.upfronthosting.co.za>
Message-ID: <1310843975.4.0.271262889404.issue409@psf.upfronthosting.co.za>


New submission from Alan Kennedy <jython-dev at xhaus.com>:

There are 4 bugs in jython tracker that are spam.

Example, Issue 1773, "cheap discount tramadol free shipping buy cheap tramadol online at lowest price us"

Please can someone delete these as a matter of urgency.

Alternatively, give me the priviledges to delete them myself, I'm a jython committer and watch the bugs list all the time.

----------
messages: 2112
nosy: amak
priority: urgent
status: unread
title: Spam on jython tracker.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue409>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sat Jul 16 21:54:33 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Sat, 16 Jul 2011 19:54:33 +0000
Subject: [Tracker-discuss] [issue409] Spam on jython tracker.
In-Reply-To: <1310843975.4.0.271262889404.issue409@psf.upfronthosting.co.za>
Message-ID: <1310846073.98.0.888587720706.issue409@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

You should already have Developer privileges on the Jython bug tracker for the 'amak' account.
Usually you just close the issue, remove the message(s) and change the title to e.g. "spam".

----------
nosy: +ezio.melotti
status: unread -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue409>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sat Jul 16 22:13:37 2011
From: metatracker at psf.upfronthosting.co.za (Alan Kennedy)
Date: Sat, 16 Jul 2011 20:13:37 +0000
Subject: [Tracker-discuss] [issue409] Spam on jython tracker.
In-Reply-To: <1310843975.4.0.271262889404.issue409@psf.upfronthosting.co.za>
Message-ID: <1310847217.22.0.68948871951.issue409@psf.upfronthosting.co.za>


Alan Kennedy <jython-dev at xhaus.com> added the comment:

OK, thanks, I did that, i.e. changed the subjects and closed them.

I tried to delete the messages and attachments, full of spam links. But I got an "Invalid request" error. Any ideas why?

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue409>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sun Jul 17 09:45:40 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?Martin_v=2E_L=C3=B6wis?=)
Date: Sun, 17 Jul 2011 07:45:40 +0000
Subject: [Tracker-discuss] [issue409] Spam on jython tracker.
In-Reply-To: <1310846073.98.0.888587720706.issue409@psf.upfronthosting.co.za>
Message-ID: <4E229322.9010507@v.loewis.de>


Martin v. L?wis <martin at v.loewis.de> added the comment:

> You should already have Developer privileges on the Jython bug tracker for the 'amak' account.
> Usually you just close the issue, remove the message(s) and change the title to e.g. "spam".

That's not appropriate. If the message is removed, it remains accessible
under it's message URL. It needs to be retired, or
marked as spam.

----------
nosy: +loewis

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue409>
_______________________________________________________

From martin at v.loewis.de  Sun Jul 17 09:45:38 2011
From: martin at v.loewis.de (=?ISO-8859-1?Q?=22Martin_v=2E_L=F6wis=22?=)
Date: Sun, 17 Jul 2011 09:45:38 +0200
Subject: [Tracker-discuss] [issue409] Spam on jython tracker.
In-Reply-To: <1310846073.98.0.888587720706.issue409@psf.upfronthosting.co.za>
References: <1310846073.98.0.888587720706.issue409@psf.upfronthosting.co.za>
Message-ID: <4E229322.9010507@v.loewis.de>

> You should already have Developer privileges on the Jython bug tracker for the 'amak' account.
> Usually you just close the issue, remove the message(s) and change the title to e.g. "spam".

That's not appropriate. If the message is removed, it remains accessible
under it's message URL. It needs to be retired, or
marked as spam.

From metatracker at psf.upfronthosting.co.za  Sun Jul 17 14:09:11 2011
From: metatracker at psf.upfronthosting.co.za (Alan Kennedy)
Date: Sun, 17 Jul 2011 12:09:11 +0000
Subject: [Tracker-discuss] [issue409] Spam on jython tracker.
In-Reply-To: <1310843975.4.0.271262889404.issue409@psf.upfronthosting.co.za>
Message-ID: <1310904551.88.0.756792184062.issue409@psf.upfronthosting.co.za>


Alan Kennedy <jython-dev at xhaus.com> added the comment:

> If the message is removed, it remains accessible
> under it's message URL. It needs to be retired, or
> marked as spam.

Yes, I would definitely prefer for the entire issues to simply be deleted.

However, there does not seem to be a "Delete Issue" capability, or at least none is offered to me at my priviledge level. What do you mean by "retire"?

As well as changing the title and closing the offending issues, I also tried to "Remove" both the individual messages and the HTML attachments on the issues, which were full of spammy links. However, both of these failed with an "Invalid request" error. Is this a bug in roundup? Or do I simply not have the privs for this operation?

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue409>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 18 09:01:53 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?Martin_v=2E_L=C3=B6wis?=)
Date: Mon, 18 Jul 2011 07:01:53 +0000
Subject: [Tracker-discuss] [issue409] Spam on jython tracker.
In-Reply-To: <1310904551.88.0.756792184062.issue409@psf.upfronthosting.co.za>
Message-ID: <4E23DA5C.3010407@v.loewis.de>


Martin v. L?wis <martin at v.loewis.de> added the comment:

> Yes, I would definitely prefer for the entire issues to simply be
> deleted.

Deletion is not supported in Roundup, by design. It's always possible to
bring things back.

Also, deletion of the issue would still keep the messages and files
available.

> What do you mean by "retire"?

Retiring is Roundup's equivalent of deletion. The object becomes
unavailable (but can be restored). It can only be invoked from the
command line.

> I also tried to "Remove" both the individual messages and the HTML
> attachments on the issues, which were full of spammy links. However,
> both of these failed with an "Invalid request" error. Is this a bug
> in roundup?

Probably so.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue409>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 19 22:14:28 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 19 Jul 2011 20:14:28 +0000
Subject: [Tracker-discuss] [issue409] Spam on jython tracker.
In-Reply-To: <1310843975.4.0.271262889404.issue409@psf.upfronthosting.co.za>
Message-ID: <1311106468.19.0.054797888526.issue409@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

Should we retire those issues, messages and files then?

I was trying to retire a file doing
  roundup> retire fileXXX
  roundup> commmit
from roundup-admin on my local tracker but even if I see 
  Date                 User   Action   Args
  2011-07-19 20:05:20  admin  retired  None
in the file history, the file is still linked to issue, I can still access it, and the id is not reused when another file is attached.

I also tried to unlink the file from the issue with
  roundup> set issueXXX files=-YYY
and 
  /issueXXX?@action=edit&@remove at files=YYY
but they both failed (also a few variants of these weren't successful).

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue409>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 19 22:26:13 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 19 Jul 2011 20:26:13 +0000
Subject: [Tracker-discuss] [issue408] Tracker development setup fails
In-Reply-To: <1309607729.46.0.543451245542.issue408@psf.upfronthosting.co.za>
Message-ID: <1311107173.84.0.86931146111.issue408@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

You could try adding a 'return' at the first line of the 'init' function in python-dev/detectors/rietveldreactor.py to disable the rietveld reactor.
I agree it would be better to have it disabled by default.

----------
nosy: +ezio.melotti, loewis
status: unread -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue408>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 19 22:34:06 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 19 Jul 2011 20:34:06 +0000
Subject: [Tracker-discuss] [issue394] Better integration with Rietveld code
	review tool
In-Reply-To: <1303156350.85.0.792534425783.issue394@psf.upfronthosting.co.za>
Message-ID: <1311107646.64.0.574034706868.issue394@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

A message would be good.

Also if we manage to add a message to the tracker, there won't be any need to send a mail from rietveld.  That will solve #382 (the CC problems) and also make email filtering easier (I still haven't managed to set up a filter able to group the reviews with the other mails from the same issue).

----------
nosy: +loewis

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue394>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 19 22:50:46 2011
From: metatracker at psf.upfronthosting.co.za (Alan Kennedy)
Date: Tue, 19 Jul 2011 20:50:46 +0000
Subject: [Tracker-discuss] [issue409] Spam on jython tracker.
In-Reply-To: <1310843975.4.0.271262889404.issue409@psf.upfronthosting.co.za>
Message-ID: <1311108646.43.0.238453615621.issue409@psf.upfronthosting.co.za>


Alan Kennedy <jython-dev at xhaus.com> added the comment:

[Elio]
> Should we retire those issues, messages and files then?

If that's the way for them to cease to exist, then please, yes. I just want for them to disappear.

They serve no purpose other than to pollute the jython tracker, lower our estimation in the eyes of jython users, lower our search engine ranking, and promote the activities of an illegal drug merchant.

[Elio]
> I was trying to retire a file doing
>   roundup> retire fileXXX
>   roundup> commmit
> from roundup-admin on my local tracker but even if I see 
>   Date                 User   Action   Args
>   2011-07-19 20:05:20  admin  retired  None
> in the file history, the file is still linked to issue, I can still access it, and the id is not reused when another file is attached.
> 
> I also tried to unlink the file from the issue with
>   roundup> set issueXXX files=-YYY
> and 
>   /issueXXX?@action=edit&@remove at files=YYY
> but they both failed (also a few variants of these weren't successful).

I'm afraid I don't know enough about roundup to assist with these issues.

Thanks for your help.

Alan.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue409>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 19 23:00:12 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 19 Jul 2011 21:00:12 +0000
Subject: [Tracker-discuss] [issue407] bug in revision linking code
In-Reply-To: <1308389788.13.0.048506676138.issue407@psf.upfronthosting.co.za>
Message-ID: <1311109212.23.0.13549698736.issue407@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

This should be fixed in r88866 (the change will be visible at the next restart).
I tweaked the regex to require at least 4 digits since revisions numbers lower than r1000 don't seem to work anyway.  This will still break if someone includes a revision number >1000, but there will always be corner cases where it fails anyway.

----------
assignedto:  -> ezio.melotti
status: chatting -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue407>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 19 23:12:58 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 19 Jul 2011 21:12:58 +0000
Subject: [Tracker-discuss] [issue382] Bad CC on review
In-Reply-To: <1301154873.73.0.955420098799.issue382@psf.upfronthosting.co.za>
Message-ID: <1311109978.23.0.861948130852.issue382@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

Adding a message on the tracker and let roundup sending a mail to the nosy members will avoid this problem.  See also #394.

----------
nosy: +ezio.melotti

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue382>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 19 23:15:25 2011
From: metatracker at psf.upfronthosting.co.za (Antoine Pitrou)
Date: Tue, 19 Jul 2011 21:15:25 +0000
Subject: [Tracker-discuss] [issue382] Bad CC on review
In-Reply-To: <1301154873.73.0.955420098799.issue382@psf.upfronthosting.co.za>
Message-ID: <1311110125.23.0.0696845957438.issue382@psf.upfronthosting.co.za>


Antoine Pitrou <pitrou at free.fr> added the comment:

True. However, it regularly bites some people and is quite unpractical.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue382>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Wed Jul 20 16:30:28 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?=C3=89ric_Araujo?=)
Date: Wed, 20 Jul 2011 14:30:28 +0000
Subject: [Tracker-discuss] [issue394] Better integration with Rietveld code
	review tool
In-Reply-To: <1303156350.85.0.792534425783.issue394@psf.upfronthosting.co.za>
Message-ID: <1311172228.13.0.526534937274.issue394@psf.upfronthosting.co.za>


?ric Araujo <merwok at netwok.org> added the comment:

Two things I think would be useful (tell me if opening other reports would be better than writing here):

- A link from the Rietveld issue to the Roundup one
- When someone writes a message on Rietveld, make them nosy on Roundup

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue394>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Wed Jul 20 16:54:25 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?=C3=89ric_Araujo?=)
Date: Wed, 20 Jul 2011 14:54:25 +0000
Subject: [Tracker-discuss] [issue391] Rietveld Code Review Tool can't handle
	well-known controls
In-Reply-To: <1302375873.9.0.391279709951.issue391@psf.upfronthosting.co.za>
Message-ID: <1311173665.07.0.976537433336.issue391@psf.upfronthosting.co.za>


?ric Araujo <merwok at netwok.org> added the comment:

I tried to upload the patch to codereview.appspot.org, to see whether your bug was due to our customization or also present in stock Rietveld, but I got this error message: Patch set contains no recognizable patches.

----------
nosy: +eric.araujo, loewis
status: unread -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue391>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Wed Jul 20 17:07:09 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?=C3=89ric_Araujo?=)
Date: Wed, 20 Jul 2011 15:07:09 +0000
Subject: [Tracker-discuss] [issue402] Unable to log in to Rietveld code
	review interface
In-Reply-To: <1306534797.29.0.437152892578.issue402@psf.upfronthosting.co.za>
Message-ID: <1311174429.59.0.131955574801.issue402@psf.upfronthosting.co.za>


?ric Araujo <merwok at netwok.org> added the comment:

Can you try changing your Rietveld name to match your Roundup one?  http://bugs.python.org/review/settings

----------
nosy: +eric.araujo
status: unread -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue402>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Wed Jul 20 17:14:57 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?=C3=89ric_Araujo?=)
Date: Wed, 20 Jul 2011 15:14:57 +0000
Subject: [Tracker-discuss] [issue410] More useful filenames for patches
	generated from hg
In-Reply-To: <1311174897.41.0.079884081521.issue410@psf.upfronthosting.co.za>
Message-ID: <1311174897.41.0.079884081521.issue410@psf.upfronthosting.co.za>


New submission from ?ric Araujo <merwok at netwok.org>:

The filenames generated by the ?Create Patch? button are hashes, which are not sortable or particularly useful.  I?d suggest something like this: issue-{number}-{sequential patch number}.diff

If it?s not possible to generate sequential patch numbers, then a timestamp could do.

----------
messages: 2128
nosy: eric.araujo, loewis, pitrou
priority: wish
status: unread
title: More useful filenames for patches generated from hg

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue410>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Wed Jul 20 17:15:46 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?=C3=89ric_Araujo?=)
Date: Wed, 20 Jul 2011 15:15:46 +0000
Subject: [Tracker-discuss] [issue406] Ugly navbar in default view
In-Reply-To: <1308379273.89.0.428297116437.issue406@psf.upfronthosting.co.za>
Message-ID: <1311174946.14.0.347729114349.issue406@psf.upfronthosting.co.za>


?ric Araujo <merwok at netwok.org> added the comment:

I don?t have that.  What?s your OS and browsers? (names and versions)

----------
nosy: +eric.araujo
status: unread -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue406>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Wed Jul 20 17:16:36 2011
From: metatracker at psf.upfronthosting.co.za (Antoine Pitrou)
Date: Wed, 20 Jul 2011 15:16:36 +0000
Subject: [Tracker-discuss] [issue410] More useful filenames for patches
	generated from hg
In-Reply-To: <1311174897.41.0.079884081521.issue410@psf.upfronthosting.co.za>
Message-ID: <1311174996.55.0.0486392011693.issue410@psf.upfronthosting.co.za>


Antoine Pitrou <pitrou at free.fr> added the comment:

+1 from me :)

----------
status: unread -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue410>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Wed Jul 20 17:24:49 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?=C3=89ric_Araujo?=)
Date: Wed, 20 Jul 2011 15:24:49 +0000
Subject: [Tracker-discuss] [issue398] Roundup Refused Update with No
	text/plain
In-Reply-To: <1304867904.05.0.182774765173.issue398@psf.upfronthosting.co.za>
Message-ID: <1311175489.81.0.532356793583.issue398@psf.upfronthosting.co.za>


?ric Araujo <merwok at netwok.org> added the comment:

I don?t find anything wrong with the attached message (BOMs, control characters).  Maybe Martin can have a look at the logs to find a more detailed error message.

----------
nosy: +eric.araujo, loewis
status: unread -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue398>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Wed Jul 20 17:31:25 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?=C3=89ric_Araujo?=)
Date: Wed, 20 Jul 2011 15:31:25 +0000
Subject: [Tracker-discuss] [issue119] Tracker Documentation
In-Reply-To: <1185340066.06.0.0886892361436.issue119@psf.upfronthosting.co.za>
Message-ID: <1311175885.71.0.914493855117.issue119@psf.upfronthosting.co.za>


?ric Araujo <merwok at netwok.org> added the comment:

I think the bugs page in the standard docs is fine as it is: a minimal page with links.  As it is released with Python, too much detail would become obsolete and do more harm than good.

The devguide should IMO be the main page to document the bug tracker: we can update and publish it independently of Python, and make it as long as we need.

The two wiki pages are IMO obsoleted by the devguide page.  Merging their content and making them redirects is fine by me.

About ease of contribution of the wiki: I think that the Python wiki is not a successful, thriving, well-maintained resource with an active community, whereas the official docs and devguide are well-tended and open to contributions through bug reports and email to docs at .  I look forward to the Sphinx extension that lets people send patches directly from the HTML pages.

----------
nosy: +eric.araujo

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue119>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Wed Jul 20 18:23:34 2011
From: metatracker at psf.upfronthosting.co.za (R David Murray)
Date: Wed, 20 Jul 2011 16:23:34 +0000
Subject: [Tracker-discuss] [issue398] Roundup Refused Update with No
	text/plain
In-Reply-To: <1304867904.05.0.182774765173.issue398@psf.upfronthosting.co.za>
Message-ID: <1311179014.88.0.933083883729.issue398@psf.upfronthosting.co.za>


R David Murray <rdmurray at bitdance.com> added the comment:

The error message is perfectly clear.  Roundup rejected the message because it didn't find the MIME headers.  It should accept the message in that case, since if there are no MIME headers it must by RFC be plain ascii text.  My mailer also generates non-MIME plain text messages, so I can't use the email interface for replying.  (Periodically I forget that and try...I usually use the web interface anyway, or I'd probably have fixed this by now...)

----------
nosy: +r.david.murray

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue398>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Wed Jul 20 20:14:55 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Wed, 20 Jul 2011 18:14:55 +0000
Subject: [Tracker-discuss] [issue394] Better integration with Rietveld code
	review tool
In-Reply-To: <1303156350.85.0.792534425783.issue394@psf.upfronthosting.co.za>
Message-ID: <1311185695.38.0.387094391178.issue394@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

I agree, writing a review on Rietveld should have the same effect as doing it on Roundup (i.e. new Roundup message (it doesn't need to contain all the review though), user added to nosy, mail sent to all the nosy members).
A link to Roundup would be good too.

Martin, is the process to install rietveld documented somewhere?
I don't have it on my local tracker, so I can't test things.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue394>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Wed Jul 20 23:42:12 2011
From: metatracker at psf.upfronthosting.co.za (Nadeem Vawda)
Date: Wed, 20 Jul 2011 21:42:12 +0000
Subject: [Tracker-discuss] [issue402] Unable to log in to Rietveld code
	review interface
In-Reply-To: <1306534797.29.0.437152892578.issue402@psf.upfronthosting.co.za>
Message-ID: <1311198132.32.0.829794986891.issue402@psf.upfronthosting.co.za>


Nadeem Vawda <nadeem.vawda at gmail.com> added the comment:

My Rietveld name already matches the one I use on Roundup ("nadeem.vawda").
Changing the Rietveld name back to "nvawda" doesn't make a difference.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue402>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Thu Jul 21 22:52:52 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?Martin_v=2E_L=C3=B6wis?=)
Date: Thu, 21 Jul 2011 20:52:52 +0000
Subject: [Tracker-discuss] [issue410] More useful filenames for patches
	generated from hg
In-Reply-To: <1311174897.41.0.079884081521.issue410@psf.upfronthosting.co.za>
Message-ID: <1311281572.86.0.339276005496.issue410@psf.upfronthosting.co.za>


Martin v. L?wis <martin at v.loewis.de> added the comment:

As a consequence of that change, if somebody presses the "create patch" button again and again, it would create a new patch each time. Currently, it finds that it already has a patch for a given revision, and aborts.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue410>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Thu Jul 21 23:19:00 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?Martin_v=2E_L=C3=B6wis?=)
Date: Thu, 21 Jul 2011 21:19:00 +0000
Subject: [Tracker-discuss] [issue398] Roundup Refused Update with No
	text/plain
In-Reply-To: <1304867904.05.0.182774765173.issue398@psf.upfronthosting.co.za>
Message-ID: <1311283140.78.0.00208889530941.issue398@psf.upfronthosting.co.za>


Martin v. L?wis <martin at v.loewis.de> added the comment:

This comes from mailgw.py. It does try to handle messages that are text/plain, and tries to treat messages with no MIME headers as text/plain. However, it overrides rfc822.Message.getheader to return '' for content-type, rather than None, which breaks the initialization of .type in mimetools.Message.

This, in turn, apparently comes from roundup 1.4.7. In upstream roundup, this has further been changed:

http://svn.roundup-tracker.org/viewvc/roundup/roundup/trunk/roundup/mailgw.py?revision=4617&view=markup

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue398>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Thu Jul 21 23:23:39 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Thu, 21 Jul 2011 21:23:39 +0000
Subject: [Tracker-discuss] [issue410] More useful filenames for patches
	generated from hg
In-Reply-To: <1311174897.41.0.079884081521.issue410@psf.upfronthosting.co.za>
Message-ID: <1311283419.68.0.280877376785.issue410@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

Adding the first few chars of the revision to the filename might solve that problem.
Even 3-4 chars should be enough if we want to keep the name short.

----------
nosy: +ezio.melotti

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue410>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 22 00:29:52 2011
From: metatracker at psf.upfronthosting.co.za (anatoly techtonik)
Date: Thu, 21 Jul 2011 22:29:52 +0000
Subject: [Tracker-discuss] [issue406] Ugly navbar in default view
In-Reply-To: <1308379273.89.0.428297116437.issue406@psf.upfronthosting.co.za>
Message-ID: <1311287392.56.0.732220402506.issue406@psf.upfronthosting.co.za>


anatoly techtonik <techtonik at gmail.com> added the comment:

It is Google Chrome 12.0.742.122. You should try it, esp. if you're maintaining some web stuff - it's awesome. The system is Vista 32.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue406>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 22 02:04:12 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?=C3=89ric_Araujo?=)
Date: Fri, 22 Jul 2011 00:04:12 +0000
Subject: [Tracker-discuss] [issue410] More useful filenames for patches
	generated from hg
In-Reply-To: <1311174897.41.0.079884081521.issue410@psf.upfronthosting.co.za>
Message-ID: <1311293052.5.0.0484463447764.issue410@psf.upfronthosting.co.za>


?ric Araujo <merwok at netwok.org> added the comment:

I?m okay for issue-{number}-{sequential patch number}-{first 6 chars of changeset id}.diff (the sequential number for human sorting, the 6 hex chars as unique identifier (the number 6 comes from a chat with Mercurial devs)).

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue410>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 22 03:18:08 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?=C3=89ric_Araujo?=)
Date: Fri, 22 Jul 2011 01:18:08 +0000
Subject: [Tracker-discuss] [issue406] Ugly navbar in default view
In-Reply-To: <1308379273.89.0.428297116437.issue406@psf.upfronthosting.co.za>
Message-ID: <1311297488.28.0.607405974245.issue406@psf.upfronthosting.co.za>


?ric Araujo <merwok at netwok.org> added the comment:

Which browser is the reference these days for CSS compliance?  My old Iceweasel (Firefox) 3.5.19 does not display the info in one small cell on the left.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue406>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 22 09:27:59 2011
From: metatracker at psf.upfronthosting.co.za (anatoly techtonik)
Date: Fri, 22 Jul 2011 07:27:59 +0000
Subject: [Tracker-discuss] [issue406] Ugly navbar in default view
In-Reply-To: <1308379273.89.0.428297116437.issue406@psf.upfronthosting.co.za>
Message-ID: <1311319679.83.0.156607264895.issue406@psf.upfronthosting.co.za>


anatoly techtonik <techtonik at gmail.com> added the comment:

There is and there won't be any reference browser. You need to have at least FF4, Chrome and IE in your stack if you're messing with a public website and care to some degree about its users.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue406>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 22 09:28:39 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Fri, 22 Jul 2011 07:28:39 +0000
Subject: [Tracker-discuss] [issue267] Make the 'remove' buttons less annoying
In-Reply-To: <1239158834.9.0.636756137699.issue267@psf.upfronthosting.co.za>
Message-ID: <1311319719.34.0.165968135761.issue267@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

The attached patch adds 
  "This message has been unlinked from issueXXX: [Restore]"
to the msg page when a message has been unlinked and not relinked yet.
When the [Restore] button is pressed the message is added back where it was and the user is sent back to the issue page.

Something like:
  "This message is linked to issueXXX: [Remove]"
could be added as well and the [Remove] buttons could be removed from the issue pages.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue267>
_______________________________________________________
-------------- next part --------------
Index: html/msg.item.html
===================================================================
--- html/msg.item.html	(revision 88842)
+++ html/msg.item.html	(working copy)
@@ -124,6 +124,18 @@
  </tr>
 </table>
 
+
+<form tal:define="u_hasRole python:request.user.hasRole;
+                  issueid python:utils.issueid_from_unlinked_msg(context)"
+      tal:condition="python:issueid and context.is_edit_ok()"
+      tal:attributes="action python:('issue%s' % issueid)" method="post">
+    <input type="hidden" name="@action" value="edit" />
+    <input type="hidden" name="@add at messages" tal:attributes="value context/id" />
+    <p>This message has been unlinked from issue<tal:block tal:replace="issueid" />:
+       <input type="submit" value="Restore" i18n:attributes="value"/></p>
+</form>
+
+
 <tal:block tal:replace="structure context/history" />
 
 </div>
Index: extensions/pydevutils.py
===================================================================
--- extensions/pydevutils.py	(revision 88865)
+++ extensions/pydevutils.py	(working copy)
@@ -14,6 +14,26 @@
     db = request.client.db
     return 'Coordinator' in db.user.get(user, 'roles')
 
+
+def issueid_from_unlinked_msg(msg):
+    """
+    If a message has been unlinked from an issue and it's still unlinked,
+    return the issues id, otherwise return None.
+    """
+    last_action = '' 
+    for entry in msg._klass.history(msg._nodeid):
+        if 'unlink' in entry:
+            last_unlink = entry
+            last_action = 'unlink'
+        elif 'link' in entry:
+            last_action = 'link'
+    if last_action == 'unlink':
+        # the msg has been unlinked and not linked back
+        # the unlink looks like: ('16', <Date 2011-07-22.05:58:32.300>, '4',
+        #                         'unlink', ('issue', '1', 'messages'))
+        return last_unlink[4][1]
+
 def init(instance):
     instance.registerUtil('is_history_ok', is_history_ok)
     instance.registerUtil('is_coordinator', is_coordinator)
+    instance.registerUtil('issueid_from_unlinked_msg', issueid_from_unlinked_msg)

From metatracker at psf.upfronthosting.co.za  Fri Jul 22 09:38:56 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Fri, 22 Jul 2011 07:38:56 +0000
Subject: [Tracker-discuss] [issue406] Ugly navbar in default view
In-Reply-To: <1308379273.89.0.428297116437.issue406@psf.upfronthosting.co.za>
Message-ID: <1311320336.94.0.308614185084.issue406@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

Interestingly, the bug is present only on http://bugs.python.org/issue and not on http://bugs.python.org/.  The problem is that the columns in the 'issue' page are different and somehow the colspan gets set to 0 rather than the correct value. Moreover, the whole thing is entangled in a set of nested tables.
I'll take a look and see if I can replace that with something saner (like a transparent spacing gif ;).

FWIW on Firefox it works fine, probably because it sets the colspan to the number of columns instead of '1' (like chrome seems to do).

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue406>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 22 11:15:35 2011
From: metatracker at psf.upfronthosting.co.za (anatoly techtonik)
Date: Fri, 22 Jul 2011 09:15:35 +0000
Subject: [Tracker-discuss] [issue406] Ugly navbar in default view
In-Reply-To: <1308379273.89.0.428297116437.issue406@psf.upfronthosting.co.za>
Message-ID: <1311326135.73.0.905629703512.issue406@psf.upfronthosting.co.za>


anatoly techtonik <techtonik at gmail.com> added the comment:

Yes. I've tried to fix that myself, but this herbicide uses TAL and I've run out of time trying to figure out where and what should I patch.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue406>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 22 13:11:45 2011
From: metatracker at psf.upfronthosting.co.za (Steffen Daode Nurpmeso)
Date: Fri, 22 Jul 2011 11:11:45 +0000
Subject: [Tracker-discuss] [issue391] Rietveld Code Review Tool can't handle
	well-known controls
In-Reply-To: <1302375873.9.0.391279709951.issue391@psf.upfronthosting.co.za>
Message-ID: <1311333105.83.0.253226423322.issue391@psf.upfronthosting.co.za>


Steffen Daode Nurpmeso <sdaoden at gmail.com> added the comment:

Heh.
It's .com.

Let me close this issue: Roundup doesn't crash - it fails dumb, but controlled.
And it's uncommon to include native controls in any Python'ish.
Doing so is *very* bad style anyway.
('Must say: a quick beauty in vim(1).)

Have a nice weekend (just roll it up from the back).

----------
status: chatting -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue391>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 22 15:34:35 2011
From: metatracker at psf.upfronthosting.co.za (R David Murray)
Date: Fri, 22 Jul 2011 13:34:35 +0000
Subject: [Tracker-discuss] [issue267] Make the 'remove' buttons less annoying
In-Reply-To: <1239158834.9.0.636756137699.issue267@psf.upfronthosting.co.za>
Message-ID: <1311341675.74.0.706389652056.issue267@psf.upfronthosting.co.za>


R David Murray <rdmurray at bitdance.com> added the comment:

+1 for moving the remove button to the message page.  I think I've used it accidentally more often than I've used it intentionally.

----------
nosy: +r.david.murray

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue267>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 22 17:11:28 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?=C3=89ric_Araujo?=)
Date: Fri, 22 Jul 2011 15:11:28 +0000
Subject: [Tracker-discuss] [issue267] Make the 'remove' buttons less annoying
In-Reply-To: <1239158834.9.0.636756137699.issue267@psf.upfronthosting.co.za>
Message-ID: <1311347488.36.0.77084857956.issue267@psf.upfronthosting.co.za>


?ric Araujo <merwok at netwok.org> added the comment:

+1.  What about files?

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue267>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 22 20:40:20 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Fri, 22 Jul 2011 18:40:20 +0000
Subject: [Tracker-discuss] [issue267] Make the 'remove' buttons less annoying
In-Reply-To: <1239158834.9.0.636756137699.issue267@psf.upfronthosting.co.za>
Message-ID: <1311360020.2.0.91176104863.issue267@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

New patch that:
 * adds "This message/file is linked to issueXXX: [Unlink]" when the msg/file is linked;
 * adds "This message/file has been unlinked from issueXXX: [Restore]" when the msg/file is unlinked;
 * removes the [remove] buttons for messages and files in the issue page.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue267>
_______________________________________________________
-------------- next part --------------
Index: extensions/pydevutils.py
===================================================================
--- extensions/pydevutils.py	(revision 88865)
+++ extensions/pydevutils.py	(working copy)
@@ -14,6 +14,29 @@
     db = request.client.db
     return 'Coordinator' in db.user.get(user, 'roles')
 
+
+def issueid_and_action_from_class(cls):
+    """
+    Return the id of the issue where the msg/file is/was linked
+    and if the last "linking action" was 'link' or 'unlink'.
+    """
+    last_action = ''
+    for entry in cls._klass.history(cls._nodeid):
+        if 'unlink' in entry:
+            last_unlink = entry
+            last_action = 'unlink'
+        elif 'link' in entry:
+            last_entry = entry
+            last_action = 'link'
+    if last_action in ('link', 'unlink'):
+        # the msg has been unlinked and not linked back
+        # the link looks like: ('16', <Date 2011-07-22.05:14:12.342>, '4',
+        #                       'link', ('issue', '1', 'messages'))
+        return last_entry[4][1], last_action
+    return None, None
+
 def init(instance):
     instance.registerUtil('is_history_ok', is_history_ok)
     instance.registerUtil('is_coordinator', is_coordinator)
+    instance.registerUtil('issueid_and_action_from_class',
+                          issueid_and_action_from_class)
Index: html/msg.item.html
===================================================================
--- html/msg.item.html	(revision 88842)
+++ html/msg.item.html	(working copy)
@@ -124,6 +124,27 @@
  </tr>
 </table>
 
+
+<form tal:define="u_hasRole python:request.user.hasRole;
+                  issueid_action python:utils.issueid_and_action_from_class(context);
+                  issueid python:'issue%s' % issueid_action[0];
+                  action python:issueid_action[1]"
+      tal:condition="python:issueid and context.is_edit_ok()"
+      tal:attributes="action issueid" method="post">
+    <input type="hidden" name="@action" value="edit" />
+    <tal:block tal:condition="python: action == 'link'">
+        <input type="hidden" name="@remove at messages" tal:attributes="value context/id" />
+        <p>This message is linked to <a tal:attributes="href issueid" tal:content="issueid" />:
+           <input type="submit" value="Unlink" i18n:attributes="value"/></p>
+    </tal:block>
+    <tal:block tal:condition="python: action == 'unlink'">
+        <input type="hidden" name="@add at messages" tal:attributes="value context/id" />
+        <p>This message has been unlinked from <a tal:attributes="href issueid" tal:content="issueid" />:
+           <input type="submit" value="Restore" i18n:attributes="value"/></p>
+    </tal:block>
+</form>
+
+
 <tal:block tal:replace="structure context/history" />
 
 </div>
Index: html/file.item.html
===================================================================
--- html/file.item.html	(revision 88842)
+++ html/file.item.html	(working copy)
@@ -81,6 +81,27 @@
       <input type="submit" name="trainham" value="Mark as HAM (not SPAM)" i18n:attributes="value">
      </form>
 
+
+<form tal:define="u_hasRole python:request.user.hasRole;
+                  issueid_action python:utils.issueid_and_action_from_class(context);
+                  issueid python:'issue%s' % issueid_action[0];
+                  action python:issueid_action[1]"
+      tal:condition="python:issueid and context.is_edit_ok()"
+      tal:attributes="action issueid" method="post">
+    <input type="hidden" name="@action" value="edit" />
+    <tal:block tal:condition="python: action == 'link'">
+        <input type="hidden" name="@remove at files" tal:attributes="value context/id" />
+        <p>This file is linked to <a tal:attributes="href issueid" tal:content="issueid" />:
+           <input type="submit" value="Unlink" i18n:attributes="value"/></p>
+    </tal:block>
+    <tal:block tal:condition="python: action == 'unlink'">
+        <input type="hidden" name="@add at files" tal:attributes="value context/id" />
+        <p>This file has been unlinked from <a tal:attributes="href issueid" tal:content="issueid" />:
+           <input type="submit" value="Restore" i18n:attributes="value"/></p>
+    </tal:block>
+</form>
+
+
 <tal:block tal:condition="context/id" tal:replace="structure context/history" />
 
 </td>
Index: html/issue.item.html
===================================================================
--- html/issue.item.html	(revision 88843)
+++ html/issue.item.html	(working copy)
@@ -240,7 +240,6 @@
   <th i18n:translate="">Uploaded</th>
   <th i18n:translate="">Description</th>
   <th i18n:translate="">Edit</th>
-  <th i18n:translate="">Remove</th>
  </tr>
  <tr tal:repeat="file python:context.files.sorted('creation')">
   <td>
@@ -258,14 +257,6 @@
       <a tal:condition="rvlink" tal:attributes="href rvlink">review</a>
       </tal:block>
   </td>
-  <td>
-   <form style="padding:0" method="post" tal:condition="file/is_edit_ok"
-         tal:attributes="action string:issue${context/id}">
-    <input type="hidden" name="@remove at files" tal:attributes="value file/id">
-    <input type="hidden" name="@action" value="edit">
-    <input type="submit" value="remove" i18n:attributes="value">
-   </form>
-  </td>
  </tr>
 </table>
 
@@ -321,14 +312,6 @@
    </th>
    <th i18n:translate="">Date: <tal:x replace="python:msg.date.pretty('%Y-%m-%d %H:%M')"
        i18n:name="date" /></th>
-   <th>
-    <form style="padding:0" method="post" tal:condition="msg/is_edit_ok"
-          tal:attributes="action string:issue${context/id}">
-     <input type="hidden" name="@remove at messages" tal:attributes="value msg/id">
-     <input type="hidden" name="@action" value="edit">
-     <input type="submit" value="remove" i18n:attributes="value">
-    </form>
-   </th>
   </tr>
   <tr>
    <td colspan="4" class="content">

From metatracker at psf.upfronthosting.co.za  Fri Jul 22 21:54:16 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Fri, 22 Jul 2011 19:54:16 +0000
Subject: [Tracker-discuss] [issue406] Ugly navbar in default view
In-Reply-To: <1308379273.89.0.428297116437.issue406@psf.upfronthosting.co.za>
Message-ID: <1311364456.24.0.511917981868.issue406@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

Attached patch kills the table and replaces it with div/span/css.
The good news are that:
 * the navbar looks like it was before;
 * the behavior is now consistent in Firefox and Chrome.
The bad news is that:
 * the navbar takes 100% of the #content, so, if there are enough columns to make the table overflow from the #content on the right, the navbar will be shorter than the table.
The good news about the bad news is that:
 * you don't have to scroll on the right of the page to find the "next >>".

Note that normally all the columns fit the width of the page.  The http://bugs.python.org/issue page is a corner case because it lists them all, making the table overflow.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue406>
_______________________________________________________
-------------- next part --------------
Index: issue.index.html
===================================================================
--- issue.index.html	(revision 88842)
+++ issue.index.html	(working copy)
@@ -93,37 +93,33 @@
   </tr>
 
  </tal:block>
-
- <metal:index define-macro="batch-footer">
- <tr tal:condition="batch">
-  <th tal:attributes="colspan python:len(request.columns)">
-   <table width="100%">
-    <tr class="navigation">
-     <th>
-      <a tal:define="prev batch/previous" tal:condition="prev"
-         tal:attributes="href python:request.indexargs_url(request.classname,
-         {'@startwith':prev.first, '@pagesize':prev.size})"
-         i18n:translate="">&lt;&lt; previous</a>
-      &nbsp;
-     </th>
-     <th i18n:translate=""><span tal:replace="batch/start" i18n:name="start"
-     />..<span tal:replace="python: batch.start + batch.length -1" i18n:name="end"
-     /> out of <span tal:replace="batch/sequence_length" i18n:name="total"
-     /></th>
-     <th>
-      <a tal:define="next batch/next" tal:condition="next"
-         tal:attributes="href python:request.indexargs_url(request.classname,
-         {'@startwith':next.first, '@pagesize':next.size})"
-         i18n:translate="">next &gt;&gt;</a>
-      &nbsp;
-     </th>
-    </tr>
-   </table>
-  </th>
- </tr>
- </metal:index>
 </table>
 
+<metal:index define-macro="batch-footer">
+ <div tal:condition="batch" class="navigation">
+     <span>
+         <a tal:define="prev batch/previous" tal:condition="prev"
+            tal:attributes="href python:request.indexargs_url(request.classname,
+            {'@startwith':prev.first, '@pagesize':prev.size})"
+            i18n:translate="">&lt;&lt; previous</a>
+         &nbsp;
+     </span>
+     <span>
+         <span tal:replace="batch/start" name="start" />..
+         <span tal:replace="python: batch.start + batch.length -1" name="end"/> out of
+         <span tal:replace="batch/sequence_length" name="total"/>
+     </span>
+     <span>
+         <a tal:define="next batch/next" tal:condition="next"
+            tal:attributes="href python:request.indexargs_url(request.classname,
+            {'@startwith':next.first, '@pagesize':next.size})"
+            i18n:translate="">next &gt;&gt;</a>
+         &nbsp;
+     </span>
+   </div>
+</metal:index>
+
+
 <a tal:attributes="href python:request.indexargs_url('issue',
             {'@action':'export_csv'})" i18n:translate="">Download as CSV</a>
 
Index: style.css
===================================================================
--- style.css	(revision 88848)
+++ style.css	(working copy)
@@ -233,18 +233,23 @@
   empty-cells: show;
 }
 
-table.list tr.navigation th {
-  width: 33%;
-  border-style: hidden;
+div.navigation {
+  background-color: #e0e0e0;
+}
+
+div.navigation span {
+  display: block;
+  width: 33.3%;
+  float: left;
   text-align: center;
+  font-weight: bold;
+  color: #234764;
+  background-color: #e0e0e0;
 }
-table.list tr.navigation td {
-    border: none
-}
-table.list tr.navigation th:first-child {
+div.navigation span:first-child {
   text-align: left;
 }
-table.list tr.navigation th:last-child {
+div.navigation span:last-child {
   text-align: right;
 }
 

From metatracker at psf.upfronthosting.co.za  Fri Jul 22 22:54:13 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?=C3=89ric_Araujo?=)
Date: Fri, 22 Jul 2011 20:54:13 +0000
Subject: [Tracker-discuss] [issue406] Ugly navbar in default view
In-Reply-To: <1308379273.89.0.428297116437.issue406@psf.upfronthosting.co.za>
Message-ID: <1311368053.57.0.346028272304.issue406@psf.upfronthosting.co.za>


?ric Araujo <merwok at netwok.org> added the comment:

FTR, the list on the b.p.o page does not exceed the width of my screen, whereas b.p.o/issue does.

Ezio, do you have a public instance of Roundup with your patch applied somewhere, or screenshots?  I can?t draw TAL or CSS in my head :)

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue406>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 22 23:28:22 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Fri, 22 Jul 2011 21:28:22 +0000
Subject: [Tracker-discuss] [issue406] Ugly navbar in default view
In-Reply-To: <1308379273.89.0.428297116437.issue406@psf.upfronthosting.co.za>
Message-ID: <1311370102.58.0.324637296573.issue406@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

Screenshots attached, navbar1 shows the overflowing table on b.p.o/issue, navbar2 the normal page on b.p.o.
I don't have enough issues to get the <<prev/next>> links, but if they turn out to be broken once I apply the patch I can always fix them later (they should be fine though).

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue406>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sat Jul 23 00:07:58 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?=C3=89ric_Araujo?=)
Date: Fri, 22 Jul 2011 22:07:58 +0000
Subject: [Tracker-discuss] [issue267] Make the 'remove' buttons less annoying
In-Reply-To: <1239158834.9.0.636756137699.issue267@psf.upfronthosting.co.za>
Message-ID: <1311372478.54.0.77891173223.issue267@psf.upfronthosting.co.za>


?ric Araujo <merwok at netwok.org> added the comment:

That sounds very good!  I think you can just go ahead and commit, we?ll get feedback on python-dev after real use just like for previous tracker improvements.

On a related note, I find the use of GETs distasteful, but that?s Roundup.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue267>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sat Jul 23 00:08:33 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?=C3=89ric_Araujo?=)
Date: Fri, 22 Jul 2011 22:08:33 +0000
Subject: [Tracker-discuss] [issue406] Ugly navbar in default view
In-Reply-To: <1308379273.89.0.428297116437.issue406@psf.upfronthosting.co.za>
Message-ID: <1311372513.81.0.435330274697.issue406@psf.upfronthosting.co.za>


?ric Araujo <merwok at netwok.org> added the comment:

+1.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue406>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sat Jul 23 00:45:48 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Fri, 22 Jul 2011 22:45:48 +0000
Subject: [Tracker-discuss] [issue267] Make the 'remove' buttons less annoying
In-Reply-To: <1239158834.9.0.636756137699.issue267@psf.upfronthosting.co.za>
Message-ID: <1311374748.79.0.382409420735.issue267@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

Fixed in r88867.
One think I noticed is that restoring a message seems to repeat all (some of?) the changes done when it was submitted the first time (e.g. adding the user to nosy).  A mail from the original user is also sent again.
The CSS might get some tweaking to center the Author and right-align the date too.

----------
assignedto:  -> ezio.melotti
status: chatting -> testing

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue267>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sat Jul 23 07:57:59 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Sat, 23 Jul 2011 05:57:59 +0000
Subject: [Tracker-discuss] [issue406] Ugly navbar in default view
In-Reply-To: <1308379273.89.0.428297116437.issue406@psf.upfronthosting.co.za>
Message-ID: <1311400679.8.0.124160778327.issue406@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

Fixed in r88868.

----------
status: in-progress -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue406>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sat Jul 23 12:24:15 2011
From: metatracker at psf.upfronthosting.co.za (anatoly techtonik)
Date: Sat, 23 Jul 2011 10:24:15 +0000
Subject: [Tracker-discuss] [issue406] Ugly navbar in default view
In-Reply-To: <1308379273.89.0.428297116437.issue406@psf.upfronthosting.co.za>
Message-ID: <1311416655.86.0.890225376785.issue406@psf.upfronthosting.co.za>


anatoly techtonik <techtonik at gmail.com> added the comment:

Good. Any chance to have this backported upstream?

----------
status: resolved -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue406>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sat Jul 23 12:25:42 2011
From: metatracker at psf.upfronthosting.co.za (anatoly techtonik)
Date: Sat, 23 Jul 2011 10:25:42 +0000
Subject: [Tracker-discuss] [issue406] Ugly navbar in default view
In-Reply-To: <1308379273.89.0.428297116437.issue406@psf.upfronthosting.co.za>
Message-ID: <1311416742.42.0.394184992922.issue406@psf.upfronthosting.co.za>


anatoly techtonik <techtonik at gmail.com> added the comment:

Is there any way to detect overflow in JS to dynamically correct columns (like removing `Python` words from version column)?

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue406>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sat Jul 23 23:27:12 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Sat, 23 Jul 2011 21:27:12 +0000
Subject: [Tracker-discuss] [issue406] Ugly navbar in default view
In-Reply-To: <1308379273.89.0.428297116437.issue406@psf.upfronthosting.co.za>
Message-ID: <1311456432.27.0.853431000886.issue406@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

I don't think it's worth porting this upstream, since it's just a workaround to fix a minor problem.  A better fix would be to redesign the page to use proper HTML semantically, and I even think some of the Roundup guys are experimenting with that.
For the same reason I don't think we should spend more time on this, especially if the fix involves JS.

----------
status: chatting -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue406>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sun Jul 24 10:50:08 2011
From: metatracker at psf.upfronthosting.co.za (anatoly techtonik)
Date: Sun, 24 Jul 2011 08:50:08 +0000
Subject: [Tracker-discuss] [issue406] Ugly navbar in default view
In-Reply-To: <1308379273.89.0.428297116437.issue406@psf.upfronthosting.co.za>
Message-ID: <1311497408.12.0.00190197511834.issue406@psf.upfronthosting.co.za>


anatoly techtonik <techtonik at gmail.com> added the comment:

What is the version of Roundup currently installed on b.p.o?

----------
status: resolved -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue406>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sun Jul 24 16:57:27 2011
From: metatracker at psf.upfronthosting.co.za (R David Murray)
Date: Sun, 24 Jul 2011 14:57:27 +0000
Subject: [Tracker-discuss] [issue406] Ugly navbar in default view
In-Reply-To: <1308379273.89.0.428297116437.issue406@psf.upfronthosting.co.za>
Message-ID: <1311519447.43.0.872680312244.issue406@psf.upfronthosting.co.za>


R David Murray <rdmurray at bitdance.com> added the comment:

1.4.10

----------
nosy: +r.david.murray

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue406>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 25 04:11:38 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Mon, 25 Jul 2011 02:11:38 +0000
Subject: [Tracker-discuss] [issue119] Tracker Documentation
In-Reply-To: <1185340066.06.0.0886892361436.issue119@psf.upfronthosting.co.za>
Message-ID: <1311559898.66.0.79995590218.issue119@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

The attached patch moves some links from the TrackerDocs wiki page to the devguide.
In the devguide there are 4 pages about the tracker:
  1) "helping triage issues" [0], in the "advanced tasks section";
  2) two paragraphs about getting the developer role [1];
  3) "triaging an issue" [2], that contains info about all the fields in the issue page;
  4) three paragraphs about marking an issue as languishing [3];

The pages 3 and 4 are sub-sections of page 2.  I think it would be better to have only two pages, one with all the information about the tracker, the meta tracker, the process, how to register/login and create a new issue, how to search issues, the developer role, the mailing list, and similar things and a second page that explains all the fields of the issue page.

[0]: http://docs.python.org/devguide/helptriage.html
[1]: http://docs.python.org/devguide/devrole.html
[2]: http://docs.python.org/devguide/triaging.html
[3]: http://docs.python.org/devguide/languishing.html

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue119>
_______________________________________________________
-------------- next part --------------
diff -r 54f788c62ef5 triaging.rst
--- a/triaging.rst	Mon Jun 27 17:54:43 2011 -0500
+++ b/triaging.rst	Mon Jul 25 04:59:55 2011 +0300
@@ -213,14 +213,28 @@
   :abbr:`PEP (Python Enhancement Proposal)` ``<number>``.
 
 
-Reporting Issues About the Tracker
-----------------------------------
-The `meta tracker`_ is the tracker about the issue tracker. It is where you
-file issues against anything you come across when working with the issue
-tracker itself.
+.. seealso::
+
+   `The Python bug tracker <http://bugs.python.org/>`_
+      Where to report issues about Python.
+
+   `The meta tracker <http://psf.upfronthosting.co.za/roundup/meta/>`_
+      Where to report issues about the tracker itself.
+
+   `The Tracker development wiki page <http://wiki.python.org/moin/TrackerDevelopment>`_
+      Instructions about setting up a local instance of the bug tracker.
+
+   `The Tracker-discuss mailing list <http://mail.python.org/mailman/listinfo/tracker-discuss>`_
+      Discussions about the bug tracker.
+
+   `The New-bugs-announce mailing list <http://mail.python.org/mailman/listinfo/new-bugs-announce>`_
+      Where all the new issues created on the tracker are reported.
+
+   `The Python-bugs-list mailing list <http://mail.python.org/mailman/listinfo/python-bugs-list>`_
+      Where all the changes to issues are reported.
 
 
 .. _GSoC: http://code.google.com/soc/
-.. _issue tracker: http://bugs.python.org
+.. _issue tracker: http://bugs.python.org/
 .. _language moratorium: http://www.python.org/dev/peps/pep-3003/
 .. _meta tracker: http://psf.upfronthosting.co.za/roundup/meta/

From metatracker at psf.upfronthosting.co.za  Mon Jul 25 04:22:00 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Mon, 25 Jul 2011 02:22:00 +0000
Subject: [Tracker-discuss] [issue409] Spam on jython tracker.
In-Reply-To: <1310843975.4.0.271262889404.issue409@psf.upfronthosting.co.za>
Message-ID: <1311560520.54.0.626310562902.issue409@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

FWIW I just got an error while trying to remove a file from #119 (using the remove button).  Maybe both this and the Jython tracker require Admin privileges to remove files submitted by others.

Martin, do you know how to retire those files/messages?

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue409>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 25 04:28:26 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Mon, 25 Jul 2011 02:28:26 +0000
Subject: [Tracker-discuss] [issue296] XSS vulnerability in ok_message
In-Reply-To: <1248205874.61.0.225589760626.issue296@psf.upfronthosting.co.za>
Message-ID: <1311560906.48.0.826448032823.issue296@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

See http://issues.roundup-tracker.org/issue2550654 and http://svn.roundup-tracker.org/viewvc/roundup?view=revision&revision=4486

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue296>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 25 16:01:32 2011
From: metatracker at psf.upfronthosting.co.za (anatoly techtonik)
Date: Mon, 25 Jul 2011 14:01:32 +0000
Subject: [Tracker-discuss] [issue411] Roundup instance is outdated
In-Reply-To: <1311602492.71.0.972062932119.issue411@psf.upfronthosting.co.za>
Message-ID: <1311602492.71.0.972062932119.issue411@psf.upfronthosting.co.za>


New submission from anatoly techtonik <techtonik at gmail.com>:

As r.david.murray pointed out in issue #406, the currently used version of Roundup on b.p.o is 1.4.10. The latest version 1.4.19 contains a lot of fixes for bugs that may be responsible for recent python.org site outages. There is also at least one serious security issue.

https://svn.roundup-tracker.org/svnroot/roundup/roundup/trunk/CHANGES.txt

----------
messages: 2165
nosy: techtonik
priority: critical
status: unread
title: Roundup instance is outdated

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue411>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 25 16:01:54 2011
From: metatracker at psf.upfronthosting.co.za (anatoly techtonik)
Date: Mon, 25 Jul 2011 14:01:54 +0000
Subject: [Tracker-discuss] [issue406] Ugly navbar in default view
In-Reply-To: <1308379273.89.0.428297116437.issue406@psf.upfronthosting.co.za>
Message-ID: <1311602514.53.0.28269968005.issue406@psf.upfronthosting.co.za>


anatoly techtonik <techtonik at gmail.com> added the comment:

Thanks. Added issue #411.

----------
status: chatting -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue406>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 25 18:19:12 2011
From: metatracker at psf.upfronthosting.co.za (Georg Brandl)
Date: Mon, 25 Jul 2011 16:19:12 +0000
Subject: [Tracker-discuss] [issue411] Roundup instance is outdated
In-Reply-To: <1311602492.71.0.972062932119.issue411@psf.upfronthosting.co.za>
Message-ID: <1311610752.81.0.130160866102.issue411@psf.upfronthosting.co.za>


Georg Brandl <g.brandl at gmx.net> added the comment:

Please make yourself familiar with the python.org infrastructure before making such claims. Roundup bugs on bugs.python.org *cannot* be responsible for outages of python.org.

----------
nosy: +gbrandl
status: unread -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue411>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 25 21:59:53 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Mon, 25 Jul 2011 19:59:53 +0000
Subject: [Tracker-discuss] [issue411] Roundup instance is outdated
In-Reply-To: <1311602492.71.0.972062932119.issue411@psf.upfronthosting.co.za>
Message-ID: <1311623993.87.0.607836308853.issue411@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

This can be done in several ways:
  * a single patch that updates everything (1.4.10 -> 1.4.19);
  * a patch for each version (1.4.x -> 1.4.(x+1) for x in range(10,19));
  * a patch for each change introduced since 1.4.10;
AFAIU, the patches should be applied to roundup-src (preserving the changes we did to it), then the instances should be updated (the html, extensions, and detectors dirs), and I think the roundup-src changes should also be copied over to the dir when roundup is installed.

Martin, is this correct? what of the 3 alternative should I use?

@techtonik: the tracker was slow lately because it was trying to get files (a couple of CSSs and the python logo) from python.org, and python.org was down (this could be fixed moving these files on b.p.o).  Apart from that, b.p.o and w.p.o are unrelated.

----------
nosy: +ezio.melotti, loewis

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue411>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 25 22:44:42 2011
From: metatracker at psf.upfronthosting.co.za (anatoly techtonik)
Date: Mon, 25 Jul 2011 20:44:42 +0000
Subject: [Tracker-discuss] [issue411] Roundup instance is outdated
In-Reply-To: <1311602492.71.0.972062932119.issue411@psf.upfronthosting.co.za>
Message-ID: <1311626682.31.0.556357644004.issue411@psf.upfronthosting.co.za>


anatoly techtonik <techtonik at gmail.com> added the comment:

I don't know about infrastructure, but ISTM that if Roundup instance is compromised, b.p.o can be put offline too.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue411>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 25 22:45:13 2011
From: metatracker at psf.upfronthosting.co.za (anatoly techtonik)
Date: Mon, 25 Jul 2011 20:45:13 +0000
Subject: [Tracker-discuss] [issue411] Roundup instance is outdated
In-Reply-To: <1311602492.71.0.972062932119.issue411@psf.upfronthosting.co.za>
Message-ID: <1311626713.0.0.0164284682834.issue411@psf.upfronthosting.co.za>


anatoly techtonik <techtonik at gmail.com> added the comment:

I've meant w.p.o

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue411>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Mon Jul 25 22:46:48 2011
From: metatracker at psf.upfronthosting.co.za (anatoly techtonik)
Date: Mon, 25 Jul 2011 20:46:48 +0000
Subject: [Tracker-discuss] [issue411] Roundup instance is outdated
In-Reply-To: <1311602492.71.0.972062932119.issue411@psf.upfronthosting.co.za>
Message-ID: <1311626808.84.0.0154717597297.issue411@psf.upfronthosting.co.za>


anatoly techtonik <techtonik at gmail.com> added the comment:

Some vectors, for example, Roundup DB with passwords, stored SVN passwords and private/public keys to jump from one server to another.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue411>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 26 07:02:01 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 26 Jul 2011 05:02:01 +0000
Subject: [Tracker-discuss] [issue390] NOSY can't be changed when an username
	has an space on it	/ usernames with spaces!
In-Reply-To: <1302182285.95.0.686747374527.issue390@psf.upfronthosting.co.za>
Message-ID: <1311656521.42.0.497581384713.issue390@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

Fixed in r88870.

FWIW JS doesn't seem to have an equivalent of .strip() that works on older browsers (there's .trim() but it's new in FF3.5 and IE9), so I had to add yet another regex.

----------
status: chatting -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue390>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 26 07:26:20 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 26 Jul 2011 05:26:20 +0000
Subject: [Tracker-discuss] [issue400] when replying by email,
	don't send another one
In-Reply-To: <1306288371.68.0.154640030812.issue400@psf.upfronthosting.co.za>
Message-ID: <1311657980.04.0.6894214382.issue400@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

Mails are sent by the sendmail.py detector[0], and for detectors there's no way to know if a submission came from the web browser or from a mail.
We could avoid sending a mail to the submitter in both the cases (browser and email), but I prefer to receive them.

[0]: http://svn.python.org/view/tracker/instances/python-dev/detectors/sendmail.py?view=markup

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue400>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 26 07:38:15 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 26 Jul 2011 05:38:15 +0000
Subject: [Tracker-discuss] [issue392] source linking for meta-tracker
In-Reply-To: <1302778456.3.0.238032301869.issue392@psf.upfronthosting.co.za>
Message-ID: <1311658695.61.0.975474963374.issue392@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

While this is not too difficult to implement (it's just a matter of copying code from the python-dev instance and adapt it), I don't think it's worth doing it.
It makes sense spending time improving and maintaining the b.p.o tracker, because there are many users.  On the other hand the meta tracker is quite low-traffic and the benefits given by such improvements are probably not worth the time spent implementing it and maintaining it.

Roundup already converts URLs to link, so an easy fix to your problem is to provide full links rather that relative paths.

----------
nosy: +ezio.melotti
status: unread -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue392>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 26 07:43:06 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 26 Jul 2011 05:43:06 +0000
Subject: [Tracker-discuss] [issue291] force closed issues to have a
	resolution
In-Reply-To: <1246311618.39.0.313946202453.issue291@psf.upfronthosting.co.za>
Message-ID: <1311658986.81.0.905715337216.issue291@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

Is this feature still desired?

FWIW I recently redirected an issue on python-ideas using the "rejected" resolution[0].

[0]: http://bugs.python.org/issue12635

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue291>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 26 07:48:47 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 26 Jul 2011 05:48:47 +0000
Subject: [Tracker-discuss] [issue120] Allow users to report msg/file
	instances as misclassified
In-Reply-To: <87sl79vn7r.fsf@uterus.efod.se>
Message-ID: <1311659327.89.0.23585790828.issue120@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

AFAIK reclassification requires "Coordinator" privileges, and there are probably a dozen of coordinators.  I think it would be OK to allow all "Developers" to reclassify messages.

I recently saw a developer asking on #python-dev if someone with enough privileges could reclassify a message, but developers that are not on IRC would have to know who has the privileges and send them a mail (or ask to tracker-discuss or something).

----------
nosy: +ezio.melotti

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue120>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 26 07:55:48 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 26 Jul 2011 05:55:48 +0000
Subject: [Tracker-discuss] [issue43] Work on html help system
In-Reply-To: <1163663008.75.0.745921730284.issue43@psf.upfronthosting.co.za>
Message-ID: <1311659748.14.0.716551505632.issue43@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

This can be closed, most of the patch has been applied already and the rest is probably outdated.  The classhelp() popups have been replaced with links to the devguide.

----------
nosy: +ezio.melotti
status: chatting -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue43>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 26 08:01:34 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 26 Jul 2011 06:01:34 +0000
Subject: [Tracker-discuss] [issue233] Using "Re:" in issue responses
In-Reply-To: <20090129203142.BDF31D912AB@montanaro.dyndns.org>
Message-ID: <1311660094.86.0.421606695663.issue233@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

Is this still a problem?

I actually prefer it without the 'Re:', since all the mail clients I use are able to figure out what is the first message and what are the responses, and having an extra 'Re:' would just add clutter to the title for me.

----------
nosy: +ezio.melotti
status: unread -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue233>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 26 08:08:41 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 26 Jul 2011 06:08:41 +0000
Subject: [Tracker-discuss] [issue169] Improve gmail interaction
In-Reply-To: <1196188531.28.0.84959205083.issue169@psf.upfronthosting.co.za>
Message-ID: <1311660521.16.0.0263428833334.issue169@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

> (b) When threading *does* work, in gmail's Inbox display, it looks like all
> messages were sent by the first author in the thread.

This seems to work now, even if the address is the same I see the real name.

I actually had the same problem after updating to Thunderbird 5 and it turned out that if you save "reports at bugs.python.org" in the address book as e.g. "Python-bugs", then "Python-bugs" will be displayed instead of the real name.
Deleting the address from the address book solved the problem.

----------
nosy: +ezio.melotti
status: chatting -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue169>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 26 09:39:17 2011
From: metatracker at psf.upfronthosting.co.za (anatoly techtonik)
Date: Tue, 26 Jul 2011 07:39:17 +0000
Subject: [Tracker-discuss] [issue392] source linking for meta-tracker
In-Reply-To: <1302778456.3.0.238032301869.issue392@psf.upfronthosting.co.za>
Message-ID: <1311665957.15.0.47939762014.issue392@psf.upfronthosting.co.za>


anatoly techtonik <techtonik at gmail.com> added the comment:

I am not convinced. Meta tracker needs to be maintained in the same way as main tracker from security standpoint alone. If the maintenance of simple code to link revision and issue numbers is too burdensome, this is an indication that:
1. the solution is badly integrated in Roundup
2. Roundup extensions mechanism is poor
3. the two points above should be raised upstream

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue392>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 26 14:54:28 2011
From: metatracker at psf.upfronthosting.co.za (R David Murray)
Date: Tue, 26 Jul 2011 12:54:28 +0000
Subject: [Tracker-discuss] [issue392] source linking for meta-tracker
In-Reply-To: <1302778456.3.0.238032301869.issue392@psf.upfronthosting.co.za>
Message-ID: <1311684868.79.0.589395056331.issue392@psf.upfronthosting.co.za>


R David Murray <rdmurray at bitdance.com> added the comment:

It doesn't mean any of those things, Anatoly.  Security issues are a separate concern.  Even if it takes ten minutes to implement the links and two to check them during an upgrade, that's still an unjustified maintenance burden for the level of traffic this tracker gets.  Now, if you want to organize a team working on tracker maintenance, that situation might change.  Right now, we just have Ezio working via GSoC (thank you Ezio!), and Martin and I when we decide to devote some of our scarce time to it.  If Ezio, who is and has done the bulk of the work on issues in this metatracker, doesn't think it is worth it, then it shouldn't be done.

Alternatively you could get actively engaged, learn the source, and start proposing patches, this one among them.  And/or, given your words, do the same upstream.

Speaking of scarce time, why did I devote some of my scarce time to answering this post?  Oh, well, the time has already been spent, I might as well post it.

----------
nosy: +r.david.murray

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue392>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 26 16:32:04 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?=C3=89ric_Araujo?=)
Date: Tue, 26 Jul 2011 14:32:04 +0000
Subject: [Tracker-discuss] [issue267] Make the 'remove' buttons less annoying
In-Reply-To: <1239158834.9.0.636756137699.issue267@psf.upfronthosting.co.za>
Message-ID: <1311690724.01.0.0897458436843.issue267@psf.upfronthosting.co.za>


?ric Araujo <merwok at netwok.org> added the comment:

This is a great change, thanks a lot.  I find it a bit strange that we jump to the bug page after clicking a button on a file page; would it be hard to stay on the file page and get the confirmation message there?

----------
status: resolved -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue267>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 26 16:56:47 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Tue, 26 Jul 2011 14:56:47 +0000
Subject: [Tracker-discuss] [issue267] Make the 'remove' buttons less annoying
In-Reply-To: <1239158834.9.0.636756137699.issue267@psf.upfronthosting.co.za>
Message-ID: <1311692207.53.0.607098571182.issue267@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

That's because the issue page is the target of the POST request, and I don't think that can't be changed.  I actually find it convenient (even if indeed somewhat unexpected), since the issue page is where I would want to go next anyway (to check if the message got remove or came back).

----------
status: chatting -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue267>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 26 22:15:21 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?Martin_v=2E_L=C3=B6wis?=)
Date: Tue, 26 Jul 2011 20:15:21 +0000
Subject: [Tracker-discuss] [issue411] Roundup instance is outdated
In-Reply-To: <1311623993.87.0.607836308853.issue411@psf.upfronthosting.co.za>
Message-ID: <4E2F2057.5070200@v.loewis.de>


Martin v. L?wis <martin at v.loewis.de> added the comment:

> This can be done in several ways:
>   * a single patch that updates everything (1.4.10 -> 1.4.19);
>   * a patch for each version (1.4.x -> 1.4.(x+1) for x in range(10,19));
>   * a patch for each change introduced since 1.4.10;

In the past, I took yet another approach: create a patch that contains
all our changes wrt. roundup, then import the current sources (of a
distinct, well-known release) into the tree replacing everything there
is, then apply the patches, checking whether they may be redundant by
now.

There is absolutely no need to mirror the roundup history in our copy,
except that we need to be able to tell what our local changes are.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue411>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 26 22:18:33 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?Martin_v=2E_L=C3=B6wis?=)
Date: Tue, 26 Jul 2011 20:18:33 +0000
Subject: [Tracker-discuss] [issue411] Roundup instance is outdated
In-Reply-To: <1311626808.84.0.0154717597297.issue411@psf.upfronthosting.co.za>
Message-ID: <4E2F2117.4030209@v.loewis.de>


Martin v. L?wis <martin at v.loewis.de> added the comment:

> Some vectors, for example, Roundup DB with passwords, stored SVN
> passwords and private/public keys to jump from one server to
> another.

Please stop talking about things you have no clue about. None of these
could possibly jump from one server to another. You are making these
problems up out of nothing. Stop spreading FUD.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue411>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Tue Jul 26 22:49:14 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?Martin_v=2E_L=C3=B6wis?=)
Date: Tue, 26 Jul 2011 20:49:14 +0000
Subject: [Tracker-discuss] [issue392] source linking for meta-tracker
In-Reply-To: <1302778456.3.0.238032301869.issue392@psf.upfronthosting.co.za>
Message-ID: <1311713354.28.0.614279251162.issue392@psf.upfronthosting.co.za>


Martin v. L?wis <martin at v.loewis.de> added the comment:

Resolving as rejected. Anatoly, please don't reopen, and don't post any further messages on this issue.

----------
nosy: +loewis
status: chatting -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue392>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Wed Jul 27 09:07:25 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Wed, 27 Jul 2011 07:07:25 +0000
Subject: [Tracker-discuss] [issue34] Generate weekly Patch/Bug status report
In-Reply-To: <87ejs9u13q.fsf@uterus.efod.se>
Message-ID: <1311750445.61.0.979226101808.issue34@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

This issue is now outdated, so I'm closing it.

----------
nosy: +ezio.melotti -dubois

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue34>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Wed Jul 27 09:08:49 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Wed, 27 Jul 2011 07:08:49 +0000
Subject: [Tracker-discuss] [issue76] Want just any user to be able to edit
	nosy list?
In-Reply-To: <1168895228.43.0.0383309268963.issue76@psf.upfronthosting.co.za>
Message-ID: <1311750529.53.0.80903334005.issue76@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

The nosy list is fine as is, and we also encourage users to add devs to the list after checking the expert index, so I'm closing this.

----------
nosy: +ezio.melotti
status: chatting -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue76>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Wed Jul 27 09:11:06 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Wed, 27 Jul 2011 07:11:06 +0000
Subject: [Tracker-discuss] [issue88] add status "needs feedback"
In-Reply-To: <1173534270.32.0.976204706628.issue88@psf.upfronthosting.co.za>
Message-ID: <1311750666.81.0.915781454434.issue88@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

I think using 'pending' is fine, so I'm closing this.

----------
nosy: +ezio.melotti
status: chatting -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue88>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Wed Jul 27 09:19:54 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Wed, 27 Jul 2011 07:19:54 +0000
Subject: [Tracker-discuss] [issue411] Roundup instance is outdated
In-Reply-To: <1311602492.71.0.972062932119.issue411@psf.upfronthosting.co.za>
Message-ID: <1311751194.98.0.802782056666.issue411@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

So the steps would be:
1) get a copy of Roundup 1.4.10 (maybe the one in vendor?);
2) create a diff between the clean 1.4.10 and "our" 1.4.10 in roundup-src;
3) get a copy of Roundup 1.4.19;
4) replace the content of roundup-src and vendor with 1.4.19;
5) apply the patch obtaind in 2) to roundup-src, adapting it if necessary;
6) commit everything (or is it better to make 2 commits (update to 1.4.19 + apply our changes)?);

Right?

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue411>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Wed Jul 27 20:40:00 2011
From: metatracker at psf.upfronthosting.co.za (=?utf-8?q?Martin_v=2E_L=C3=B6wis?=)
Date: Wed, 27 Jul 2011 18:40:00 +0000
Subject: [Tracker-discuss] [issue411] Roundup instance is outdated
In-Reply-To: <1311751194.98.0.802782056666.issue411@psf.upfronthosting.co.za>
Message-ID: <4E305B7E.2050502@v.loewis.de>


Martin v. L?wis <martin at v.loewis.de> added the comment:

> 1) get a copy of Roundup 1.4.10 (maybe the one in vendor?);

I think I misremember how I did the last update; in any case, this was
done in r76545, and cites http://pypi.python.org/pypi/roundup/1.4.10
as the source that was used. It may have been a diff to 1.4.8 indeed.
The procedure I described before was apparently last used for upgrading
to 1.4.7.

The "vendor" directory isn't used anymore; Erik intended it to support
better merging, but when I tried to use it, the merging failed because
of the substantial changes.

> 2) create a diff between the clean 1.4.10 and "our" 1.4.10 in roundup-src;
> 3) get a copy of Roundup 1.4.19;
> 4) replace the content of roundup-src and vendor with 1.4.19;
> 5) apply the patch obtaind in 2) to roundup-src, adapting it if necessary;
> 6) commit everything (or is it better to make 2 commits (update to 1.4.19 + apply our changes)?);
> 
> Right?

That's what I would propose, yes - assuming you have the energy to
review all of our local changes again. If not, you can as well try
creating a patch between 1.4.10 and 1.4.19, and try applying that.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue411>
_______________________________________________________

From martin at v.loewis.de  Wed Jul 27 20:39:58 2011
From: martin at v.loewis.de (=?ISO-8859-1?Q?=22Martin_v=2E_L=F6wis=22?=)
Date: Wed, 27 Jul 2011 20:39:58 +0200
Subject: [Tracker-discuss] [issue411] Roundup instance is outdated
In-Reply-To: <1311751194.98.0.802782056666.issue411@psf.upfronthosting.co.za>
References: <1311751194.98.0.802782056666.issue411@psf.upfronthosting.co.za>
Message-ID: <4E305B7E.2050502@v.loewis.de>

> 1) get a copy of Roundup 1.4.10 (maybe the one in vendor?);

I think I misremember how I did the last update; in any case, this was
done in r76545, and cites http://pypi.python.org/pypi/roundup/1.4.10
as the source that was used. It may have been a diff to 1.4.8 indeed.
The procedure I described before was apparently last used for upgrading
to 1.4.7.

The "vendor" directory isn't used anymore; Erik intended it to support
better merging, but when I tried to use it, the merging failed because
of the substantial changes.

> 2) create a diff between the clean 1.4.10 and "our" 1.4.10 in roundup-src;
> 3) get a copy of Roundup 1.4.19;
> 4) replace the content of roundup-src and vendor with 1.4.19;
> 5) apply the patch obtaind in 2) to roundup-src, adapting it if necessary;
> 6) commit everything (or is it better to make 2 commits (update to 1.4.19 + apply our changes)?);
> 
> Right?

That's what I would propose, yes - assuming you have the energy to
review all of our local changes again. If not, you can as well try
creating a patch between 1.4.10 and 1.4.19, and try applying that.

From metatracker at psf.upfronthosting.co.za  Fri Jul 29 11:21:01 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Fri, 29 Jul 2011 09:21:01 +0000
Subject: [Tracker-discuss] [issue334] remote bug watchers
In-Reply-To: <1271274318.29.0.317511707543.issue334@psf.upfronthosting.co.za>
Message-ID: <1311931261.97.0.594325317341.issue334@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

This should be reported upstream.

----------
assignedto:  -> ezio.melotti
nosy: +ezio.melotti
status: unread -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue334>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 29 11:23:06 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Fri, 29 Jul 2011 09:23:06 +0000
Subject: [Tracker-discuss] [issue218] Inline Patch options for python-bugs
	list and roundup email
In-Reply-To: <1220585553.16.0.432911761102.issue218@psf.upfronthosting.co.za>
Message-ID: <1311931386.91.0.917549408431.issue218@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

I agree with Brett, especially now that we have rietveld and reviews on plain diffs are becoming less common.

----------
assignedto:  -> ezio.melotti
nosy: +ezio.melotti
status: chatting -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue218>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 29 15:30:49 2011
From: metatracker at psf.upfronthosting.co.za (anatoly techtonik)
Date: Fri, 29 Jul 2011 13:30:49 +0000
Subject: [Tracker-discuss] [issue334] remote bug watchers
In-Reply-To: <1271274318.29.0.317511707543.issue334@psf.upfronthosting.co.za>
Message-ID: <1311946249.7.0.723525404169.issue334@psf.upfronthosting.co.za>


anatoly techtonik <techtonik at gmail.com> added the comment:

I don't think so. It is a feature that's important for the development of Python language by looking at how some particular bugs affect other open source projects. Most Roundup users don't need it.

----------
status: resolved -> chatting

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue334>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Fri Jul 29 16:06:55 2011
From: metatracker at psf.upfronthosting.co.za (R David Murray)
Date: Fri, 29 Jul 2011 14:06:55 +0000
Subject: [Tracker-discuss] [issue334] remote bug watchers
In-Reply-To: <1271274318.29.0.317511707543.issue334@psf.upfronthosting.co.za>
Message-ID: <1311948415.32.0.99954610604.issue334@psf.upfronthosting.co.za>


R David Murray <rdmurray at bitdance.com> added the comment:

No.  Your example of launchpad proves that this is a widely applicable feature.  So I agree with Ezio, this feature request belongs upstream.

----------
nosy: +r.david.murray
status: chatting -> resolved

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue334>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sat Jul 30 18:18:38 2011
From: metatracker at psf.upfronthosting.co.za (Sandro Tosi)
Date: Sat, 30 Jul 2011 16:18:38 +0000
Subject: [Tracker-discuss] [issue412] Allow for more than one attach file
In-Reply-To: <1312042718.83.0.0575637618374.issue412@psf.upfronthosting.co.za>
Message-ID: <1312042718.83.0.0575637618374.issue412@psf.upfronthosting.co.za>


New submission from Sandro Tosi <sandro.tosi at gmail.com>:

Currently we can only attach one file at a time, while there are several situations when you have more to attach per "submit" - just f.e. when you're preparing a patch for 2.7 and 3.x that they usually are different. Being able to attach them both at the same time instead of "attach first + submit + attach the second waiting for the page to reload + submit" would be really nice

----------
messages: 2196
nosy: sandro.tosi
priority: feature
status: unread
title: Allow for more than one attach file

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue412>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sun Jul 31 15:41:45 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Sun, 31 Jul 2011 13:41:45 +0000
Subject: [Tracker-discuss] [issue411] Roundup instance is outdated
In-Reply-To: <1311602492.71.0.972062932119.issue411@psf.upfronthosting.co.za>
Message-ID: <1312119705.62.0.927781715091.issue411@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

BTW, there were two conflicts that might cause some problems, the first is in cgi/client.py[0]:
Our copy:
        # MvL 20100404: catch IndexError
        try:
            mime_type = klass.get(nodeid, 'type')
        except IndexError:
            raise NotFound, designator
Roundup 1.4.19:
        mime_type = klass.get(nodeid, 'type')
        # Can happen for msg class:
        if not mime_type:
            mime_type = 'text/plain'
Here I decided to use the roundup version.

The second is in cgi/templating.py[1]:
Our copy:
-    def batch(self):
+    def batch(self, to_ignore='ignore'):
         """ Return a batch object for results from the "current search"
         """
         filterspec = self.filterspec
         sort = self.sort
         group = self.group
+        ignore = self.get_ignored(to_ignore)

Roundup 1.4.19:
-    def batch(self):
+    def batch(self, permission='View'):
         """ Return a batch object for results from the "current search"
         """
+        check = self._client.db.security.hasPermission
+        userid = self._client.userid
+        if not check('Web Access', userid):
+            return Batch(self.client, [], self.pagesize, self.startwith,
+                classname=self.classname)

Merge result:
    def batch(self, permission='View', to_ignore='ignore'):
        """ Return a batch object for results from the "current search"
        """
        check = self._client.db.security.hasPermission
        userid = self._client.userid
        if not check('Web Access', userid):
            return Batch(self.client, [], self.pagesize, self.startwith,
                classname=self.classname)

        filterspec = self.filterspec
        sort = self.sort
        group = self.group
        ignore = self.get_ignored(to_ignore)

It's not clear from the code alone if these args are called by name (i.e. no problems) or by position (might cause problems if to_ignore is called first), so I'll have to do some testing.


[0]: http://svn.python.org/view?view=revision&revision=79749
[1]: http://svn.python.org/view?view=revision&revision=82976

----------
assignedto:  -> ezio.melotti

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue411>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sun Jul 31 17:10:22 2011
From: metatracker at psf.upfronthosting.co.za (R David Murray)
Date: Sun, 31 Jul 2011 15:10:22 +0000
Subject: [Tracker-discuss] [issue411] Roundup instance is outdated
In-Reply-To: <1311602492.71.0.972062932119.issue411@psf.upfronthosting.co.za>
Message-ID: <1312125022.29.0.481586512923.issue411@psf.upfronthosting.co.za>


R David Murray <rdmurray at bitdance.com> added the comment:

> Here I decided to use the roundup version.

Why?  Absent further context I would assume that Martin added that try/except to fix a bug.  If upstream has since fixed it differently, leaving Martin's code in place should be a noop, whereas if it hasn't been fixed leaving it in place will prevent a regression.

----------
nosy: +r.david.murray

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue411>
_______________________________________________________

From metatracker at psf.upfronthosting.co.za  Sun Jul 31 18:49:53 2011
From: metatracker at psf.upfronthosting.co.za (Ezio Melotti)
Date: Sun, 31 Jul 2011 16:49:53 +0000
Subject: [Tracker-discuss] [issue411] Roundup instance is outdated
In-Reply-To: <1311602492.71.0.972062932119.issue411@psf.upfronthosting.co.za>
Message-ID: <1312130993.08.0.815874973388.issue411@psf.upfronthosting.co.za>


Ezio Melotti <ezio.melotti at gmail.com> added the comment:

I just assumed that the two different solutions fixed the same problem.
The roundup issue [0], fixes a traceback generated while accessing e.g. /msg1/, whereas our issue [1] was about accessing files.  The two exceptions are different though, so there might be two different issues involved.

One reason to keep the roundup version is that it will make future merges easier -- assuming that it solve the problem.
I'll try to figure out if this is the case or not.

[0]: http://issues.roundup-tracker.org/issue2550586
[1]: http://psf.upfronthosting.co.za/roundup/meta/issue326 (last 3 messages)

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue411>
_______________________________________________________