[spambayes-bugs] [ spambayes-Patches-1679796 ] DoBrowse() dialog broken

[SourceForge.net]

Patches item #1679796, was opened at 2007-03-14 00:35
Message generated for change (Comment added) made by mhammond
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498105&aid=1679796&group_id=61702

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Outlook
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Marko von Oppen (igs)
Assigned to: Nobody/Anonymous (nobody)
Summary: DoBrowse() dialog broken

Initial Comment:
On all my test systems (WinXP/WinVistaX64 / OL2007 / Python 2.4.4 / Pythonwin 210) clicking on the 'Browse' buttons in SpamBayes Manager on tab 'Notifications' gave an exception:

TypeError: Argument must be a 88-byte string

I couldn't find out the exact reason of the error because a shortage of documentation. So I wrote a reimplementation using GetOpenFileNameW() instead of GetOpenFileName().

I don't know if the previous code works on older versions of pythonwin32. So I left the old code unchanged and I think that this workaround maybe is the best solution for the problem.

----------------------------------------------------------------------

>Comment By: Mark Hammond (mhammond)
Date: 2007-03-14 11:45

Message:
Logged In: YES 
user_id=14198
Originator: NO

It still works fine for me with the current CVS of pywin32.  The code in
question references 'sizeof(OPENFILENAME)' - is it possible you are
building your own pywin32, and the windows headers you use have a different
definition of OPENFILENAME?

Looking at CommDlg.h, I see there are various different OPENFILENAME
structures (eg, LPOPENFILENAME_NT4) - that is probably the root cause of
the problem.  I'm reluctant to apply this patch without better
understanding the problem you are seeing.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498105&aid=1679796&group_id=61702