[spambayes-bugs] [ spambayes-Patches-790615 ] Allowed remote connections management

[SourceForge.net]

Patches item #790615, was opened at 2003-08-19 03:32
Message generated for change (Comment added) made by anadelonbrin
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498105&aid=790615&group_id=61702

Category: None
Group: None
Status: Closed
Resolution: Accepted
Priority: 5
Submitted By: Romain Guy (gfx)
Assigned to: Nobody/Anonymous (nobody)
Summary: Allowed remote connections management

Initial Comment:
Right now, SpamBayes let the user choose between
allowing either any one to log into the web interface,
either localhost only.

This patch let the user managed the remote connections
in a better way, with a single field. It appears in the
Proxy options, in the configuration page and accepts
the following values :

* - Allows any remote connection to log in
localhost - Only localhost is allowed
192.168.0.4 - A specific IP is allowed
192.168.0.4,192.168.0.5 - Two specific IPs are allowed
192.168.0.* - A range of IPs is allowed
192.*.1.* - Another kind of range

Note that * (the default value) is similar to *.*.*.*

The regex used check if the IPs are valid. Thus,
257.1.2.3 won't be allowed. The attached zip file
contains the diff against current CVS version as well
as the .py files if you want to overwrite your files
directly.

I only have a two computers LAN here and it worked
well. Yet, I'll be glad if you helped testing this
patch :-)

----------------------------------------------------------------------

>Comment By: Tony Meyer (anadelonbrin)
Date: 2003-08-19 20:55

Message:
Logged In: YES 
user_id=552329

Note that this closes:
[ spambayes-Feature Requests-698036 ] pop3proxy security
https://sourceforge.net/tracker/?
func=detail&atid=498106&aid=698036&group_id=61702


----------------------------------------------------------------------

Comment By: Tony Meyer (anadelonbrin)
Date: 2003-08-19 20:53

Message:
Logged In: YES 
user_id=552329

Checked in, thanks.

(BTW, I trusted the regex and the non */localhost bit of the 
code - I presume you tested it enough... :)

If you want to improve on it to add subranges, then go ahead 
and submit a patch; I think this is sufficient for most people.

----------------------------------------------------------------------

Comment By: Romain Guy (gfx)
Date: 2003-08-19 03:34

Message:
Logged In: YES 
user_id=6845

One more thing : you can perfectly mix specific IPs with
ranges like this :
192.168.0.*,253.94.17.2,80.53.*.*

Maybe could we consider adding subranges (for instance :
192.168.0.[4-10])

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498105&aid=790615&group_id=61702