[Shtoom] visible passwords

Dafydd Harries daf at muse.19inch.net
Mon Feb 7 13:00:14 CET 2005


I've noticed that the register_authpasswd option is a StringOption
rather than a PasswordOption. Attached is a patch to fix this. While
fixing this, I also found a password widget in the Glade file for the
auth dialog (which I've never actually seen instantiated) which has
visibility set to True. The patch fixes this also.

-- 
Dafydd
-------------- next part --------------
Index: shtoom/opts.py
===================================================================
--- shtoom/opts.py	(revision 1234)
+++ shtoom/opts.py	(working copy)
@@ -12,7 +12,7 @@
     return username
 
 def buildOptions(app):
-    from shtoom.Options import AllOptions, OptionGroup, StringOption, NumberOption, ChoiceOption, BooleanOption
+    from shtoom.Options import AllOptions, OptionGroup, StringOption, PasswordOption, NumberOption, ChoiceOption, BooleanOption
     opts = AllOptions()
 
     app.appSpecificOptions(opts)
@@ -43,7 +43,7 @@
                         'URI of registration server (e.g. sip:divmod.com:5060)'))
     register.addOption(StringOption('register_user','Username to register'))
     register.addOption(StringOption('register_authuser','Username to use for auth'))
-    register.addOption(StringOption('register_authpasswd','Passwd to use for auth'))
+    register.addOption(PasswordOption('register_authpasswd','Passwd to use for auth'))
     opts.addGroup(register)
 
     debug = OptionGroup('debug', 'Debugging', gui=False)
Index: shtoom/ui/gnomeui/shtoom.glade
===================================================================
--- shtoom/ui/gnomeui/shtoom.glade	(revision 1234)
+++ shtoom/ui/gnomeui/shtoom.glade	(working copy)
@@ -519,7 +519,7 @@
 		  <property name="visible">True</property>
 		  <property name="can_focus">True</property>
 		  <property name="editable">True</property>
-		  <property name="visibility">True</property>
+		  <property name="visibility">False</property>
 		  <property name="max_length">0</property>
 		  <property name="text" translatable="yes"></property>
 		  <property name="has_frame">True</property>


More information about the Shtoom mailing list