[SciPy-Dev] Messages stuck in moderation ?

[Ralf Gommers]

On Thu, Feb 4, 2021 at 8:41 PM Matthias Bussonnier <
bussonniermatthias at gmail.com> wrote:

> Hello everyone,
>
> I am working with a student (Arthur Volant) on his first contribution to
> SciPy,
> It looks like his mails are not reaching the mailing list (they do not
> currently appear in archive[0]).
>
> Does anybody have access to the moderation panel to see if they are
> stuck in moderation or if something else is rejecting them ? Or is
> there a problem on mailman which does not display them, but
> subscribers to the mailing list still did receive them ?
>

Hey Mathias, no one on this list has admin access. Best would be to submit
an issue through the email address at the bottom of
https://mail.python.org/mailman/listinfo/scipy-dev.


> Below is attached a copy of the messages sent.
>
> Thanks,
> --
> Matthias
>
>
> from: arthurvolant at gmail.com
> Hello Scipy-dev,
>
> I have been working for a couple of days now on the following PR[1].
> The origin of this PR is this issue[2], asking to add Barnard and
> Boschloo test, which are two exact statistical tests.
> While working on it, I found that Fisher's exact test was already
> implemented.
> Barnard and Boshloo are two tests more powerful than Fisher's one.
> My `barnard_exact` implementation is so far working well. It is a
> little bit slower than Fisher exact test, but not that much, with an
> average execution time of 1.12 ms
>

Both of these tests seem like a good idea to add. Feedback on the issue was
positive, and the papers have ~350 and ~150 citations, respectively. So
that should be good enough.


> I was wondering though where to put my codes. It seems that there are
> two possible files :
> either in `scipy/stats/_hypotests.py` or either in
> `scipy/stats/contingency.py` which contains already `chi2_contingency`
> function. What would you advise me to do?
>

The PR as it is, adding it to _hypotests.py, seems fine to me.

Thanks for working on this Arthur!

Cheers,
Ralf




> I thank you for your time and answers,
> Arthur
>
> 0:
> https://mail.python.org/pipermail/scipy-dev/2021-February/date.html#start
> 1: https://github.com/scipy/scipy/pull/13441
> 2: https://github.com/scipy/scipy/issues/11014
> _______________________________________________
> SciPy-Dev mailing list
> SciPy-Dev at python.org
> https://mail.python.org/mailman/listinfo/scipy-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.python.org/pipermail/scipy-dev/attachments/20210205/d98a93d5/attachment-0001.html>