[SciPy-Dev] On the topic of separate merge commits

[Matthew Brett]

Hi,

On Tue, Aug 24, 2021 at 4:51 PM Tyler Reddy <tyler.je.reddy at gmail.com> wrote:
>
> > Hence I thought you would be the best placed to answer my interrogations.
>
> I am certainly not the appropriate person to target for "interrogations" on this matter. It is a long-standing practice in the community, and a feature GitHub has in their GUI to create separate merge commits even when there is only a single commit in the PR.
>
> If SciPy or the community strongly prefers not to do it, then I'll switch to squashing, but until then I strongly disagree that I should have to defend PRs where I do that.

I must say - that's what I tend to do (merge, not squash).   I can see
arguments for squashing, if the history is very messy, but if the
history is good, and the commits are well organized, squashing seems
like the wrong thing to do.   Why not leave it to the judgement of the
person doing the merge?

Cheers,

Matthew