[SciPy-Dev] Missing whitespace after commas in pycodestyle check

Andrew Nelson andyfaff at gmail.com
Tue Jan 14 02:02:56 EST 2020


>
>
>>> Another option would be to run pycodestyle/pyflakes with all checks we
>> want enabled, but only on the diff in the PR. This is what PyTorch does for
>> example. The nice thing is you can test what you want without having to
>> deal with code churn before enabling a check. The downside is that it's a
>> bit convoluted to reproduce the "run on the diff to master" command locally
>> (but we could add a script to streamline that probably).
>>
>
I'd prefer to do this. There are various PEP8 things that would be nice to
have uniformly implemented throughout the codebase. I don't think we should
let them slide by during a normal PR (because we'll never reach the ideal),
so having a check on the diff is a good compromise. FWIW I did the change
wholesale for a project of mine, and it is definitely more pleasing on the
eye. It took me a couple of hours, and once it's done it's done. Then one
can crack down.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scipy-dev/attachments/20200114/2a7c746e/attachment.html>


More information about the SciPy-Dev mailing list