[SciPy-Dev] Newbie question: submitting PRs, review

[Shubham Mishra]

Hey,
I am a newbie too. I recently merged 1 PR. Here is what I did:
1. Communicated over the issue on Github issue page (In your case, you
might have to raise one)
2. Went through the Contribution guidelines.
3. Forked the repo and created a dev environment.
4. Made the required changes.
5. Raised a PR and asked for review.

You can go through HACKING.rst.txt on the root directory of the repo for
reference.

Hope this helps.
Warm regards,
Shubham Mishra (grapheo12)

On Sat, 15 Feb 2020, 10:22 Tom Roderick, <thomas.roderick at gmail.com> wrote:

> Hi folks
>
> This is my first time mailing the list, so forgive me if I come across
> naive -- it is because I am!
>
> I noticed that the metric in scipy.spatial.distance.sokalmichener is the
> wrong metric, as per many sources (e.g.
> https://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.352.6123&rep=rep1&type=pdf)
> -- the rogerstanimoto dissimilarity is in its place. I'd like to correct
> it, but am not 100% sure I understand the process.
>
> So, wanted to reach out to the mailing list and hopefully get some
> mentoring. Is the Scipy process as simple as: fix code, add unit test,
> submit Github PR?
>
> Best,
> -Tom
> _______________________________________________
> SciPy-Dev mailing list
> SciPy-Dev at python.org
> https://mail.python.org/mailman/listinfo/scipy-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scipy-dev/attachments/20200215/5d6f39ed/attachment-0001.html>