[SciPy-Dev] Github workflow

[Ryan May]

On Fri, Oct 11, 2019 at 1:17 PM Pauli Virtanen <pav at iki.fi> wrote:

> pe, 2019-10-11 kello 13:10 -0600, Ryan May kirjoitti:
> [clip]
> > I'm in favor of having the "request new review" or making it easier
> > to query. I just want to clarify that under "Branch Protection" you
> > can actually set that reviews are cleared on new pushes:
>
> Interesting, I hadn't noticed that --- but it says it clears approvals.
> Does it also clear negative reviews (the case more important for me)


Interesting, I just read through that before and didn't think about the
distinction...

I just checked a PR on my repo and, no, it does not clear "request changes"
reviews. So there's a GitHub workflow improvement that would be nice:
dismiss *all* reviews on push.

Ryan

-- 
Ryan May
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scipy-dev/attachments/20191011/5083b147/attachment.html>