[SciPy-Dev] Github workflow

[Ryan May]

>
> >
> > Add a button the PR submitter / maintainers can press, which adds a
> > status marker for "requesting further review from *someone*". New PRs
> > would have the status flag set, and the submitter could use this to
> > mark a PR ready after making requested changes.
>
> I'd also like to note that Aaron Meurer's blog post makes a similar
> point (although pushing commits instead of a button):
>
> https://www.asmeurer.com/blog/posts/github-reviews-gripes/
>
> """
> Next gripe, and this, I want to stress, makes the whole feature
> completely useless for my needs: reviews do not reset when new commits
> are pushed.
>

I'm in favor of having the "request new review" or making it easier to
query. I just want to clarify that under "Branch Protection" you can
actually set that reviews are cleared on new pushes:

[image: image.png]

Ryan


-- 
Ryan May
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scipy-dev/attachments/20191011/83f43d6f/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image.png
Type: image/png
Size: 240406 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/scipy-dev/attachments/20191011/83f43d6f/attachment-0001.png>