[SciPy-Dev] adding more window functions to scipy.signal

Nathaniel Smith njs at pobox.com
Fri Jan 6 00:07:44 EST 2017


On Thu, Jan 5, 2017 at 8:58 PM, Ralf Gommers <ralf.gommers at gmail.com> wrote:
> Hi all,
>
> There are 3 PRs open for adding new window functions to scipy.signal:
> - Kaiser-Bessel, https://github.com/scipy/scipy/pull/4747
> - Planck, https://github.com/scipy/scipy/pull/6012 (also interest in adding
> Planck-Bessel there)
> - Lanczos, https://github.com/scipy/scipy/pull/6837
>
> So far Kaiser-Bessel and Lanczos got a positive reception, Planck didn't
> because it looks too specific - only uses found are in gravitational wave
> research.
>
> One of the annoyances with the window functions is that they really clutter
> the signal namespace as we keep on adding more. We have two options I think:
>
> 1. Keep on adding new window functions with the current style (provided that
> they're general enough, i.e. used in more than one field).
> 2. Only add them behind a unified interface, like signal.get_window. Could
> also be a new interface, not everyone is a fan of get_window (see
> https://github.com/scipy/scipy/pull/6837).

Not sure what you're pointing to with that link, but isn't get_window
basically reinventing the concept of the python namespace? Maybe
declare scipy.signal.windows (which already exists!) to be the public
namespace where you find your windows?

-n

-- 
Nathaniel J. Smith -- https://vorpus.org



More information about the SciPy-Dev mailing list