[SciPy-Dev] github: disappearing comments - clarification?

[Ralf Gommers]

On Thu, May 17, 2012 at 10:30 PM, <josef.pktd at gmail.com> wrote:

> A question for the github experts:
>
> Under what scenarios do comments on github pull requests disappear?
>
> I've never seen a clear answer just my speculation. (based on: Did it
> disappear or is my search fu insufficient?)
>
> For example, some comments disappear after a rebased force push. all
> comments or just inline code comments?
>

Only inline comments on commits that have been rebased/deleted should
disappear. Github is also smart enough to update links for commits that get
merged from the repo where the PR came from to the repo into which it got
merged.


> If a pull request never gets merged and the originating branch is
> deleted, do the comments also disappear?
>
> Yes, I think so.


> any other cases of disappearing comments?
>
> Not that I'm aware of.

Ralf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scipy-dev/attachments/20120519/1ebc17c0/attachment.html>