[SciPy-Dev] pull requests and code review
Travis Oliphant
travis at continuum.io
Thu Jan 5 19:41:39 EST 2012
I don't think there should be any time limit on pull requests. Who is the *we* that needs time to look at them. I did take time to look at the changes. The code changes were not extensive (except for the very nice tests), and it is a welcome change.
Your feedback on the use of inspect is very good. We can take a look at whether or not it method calls were considered and fix it if it does.
If you are interested in continuing to review all the optimize changes, I will make sure and give you time to review in the future. This is where having a list of interested and available parties for different modules would make a great deal of sense.
Thanks,
-Travis
On Jan 5, 2012, at 6:19 PM, josef.pktd at gmail.com wrote:
> Can we keep pull requests open for more than 3 hours, so we actually
> have time to look at them.
>
> looking at
> https://github.com/scipy/scipy/commit/c9c2d66701583984589c88c08c478e2fc6d9f4ec#L1R1213
>
> my first guess is that the use of inspect.getargspec breaks when the
> hessian is a method attached to a class, as we have almost all our
> code in statsmodels.
> We just fixed a similar case in scipy.
>
> There should be at least time to check whether this kind of suspicions
> are justified or not.
>
> Josef
> _______________________________________________
> SciPy-Dev mailing list
> SciPy-Dev at scipy.org
> http://mail.scipy.org/mailman/listinfo/scipy-dev
More information about the SciPy-Dev
mailing list