[SciPy-Dev] np.savetxt: apply patch in enhancement ticket 1079 to add headers?

[Bruce Southey]

On 06/04/2010 11:03 AM, Skipper Seabold wrote:
> On Fri, Jun 4, 2010 at 11:49 AM, Stefan<stefan.czesla at hs.uni-hamburg.de>  wrote:
>    
>> Dear all,
>>
>> as a consequence of our discussion, we developed a patch (attached to
>> ticket 1079), which implements some of the features discussed here.
>> We concentrated on comments and the header. Please have a look at the
>> patch. We are looking forward to hearing your opinion and suggestions,
>> and whether you see any problems, which could prevent it from entering the
>> official release.
>>
>>      
> Link: http://projects.scipy.org/numpy/ticket/1079
>
> One comment.  Maybe you can add in the notes that the comment keyword
> can be used to write a header and still preserve compatibility with
> loadtxt.  This wasn't obvious to me at first, though maybe that's just
> me.
>
> Other than that I think it looks like a good first effort towards
> making this a better function and I appreciate the attention here.
>
> Skipper
>
>    
>> We agree with Bruce that the format string should be inferred from the
>> data type of the array. Yet, we believe that this point should be
>> addressed in a different patch focussing on that topic.
>>
>> Also we noted that there is no error checking, when an array of dimension
>> larger 2 is handed to np.savetxt, which may be implemented easily.
>>
>> Stefan&  Christian
>>
>> _______________________________________________
>> SciPy-Dev mailing list
>> SciPy-Dev at scipy.org
>> http://mail.scipy.org/mailman/listinfo/scipy-dev
>>
>>      
> _______________________________________________
> SciPy-Dev mailing list
> SciPy-Dev at scipy.org
> http://mail.scipy.org/mailman/listinfo/scipy-dev
>    
Hi,
For the sake of similarity to loadtxt keywords (because loadtxt has them 
and changing those is harder than adding new ones to savetxt):
1) 'comment_character' should be 'comments'
2) instead of 'comment' perhaps use 'preamble'

Thanks for doing the patch so quickly!


Bruce