[SciPy-dev] scikits.umfpack
Nils Wagner
nwagner at iam.uni-stuttgart.de
Thu Aug 7 06:55:44 EDT 2008
On Thu, 07 Aug 2008 12:40:04 +0200
Robert Cimrman <cimrman3 at ntc.zcu.cz> wrote:
> Ondrej Certik wrote:
>> On Wed, Aug 6, 2008 at 1:15 PM, Robert Cimrman
>><cimrman3 at ntc.zcu.cz> wrote:
>>> Related question: what versions of scipy/numpy should be
>>>scikits
>>> compatible with? I will try to update umfpack to work
>>>both with the last
>>> release and the svn.
>>
>> Well Robert, maybe it's time you start sending patches
>>for a review, no? :)
>>
>> I am sure Stefan would agree with me. :)
>
> Although I agree that reviews are nice, the patch was ok
>- before
> UMFPACK scikit did not work. I just missed the failing
>test, caused by
> test_umfpack.py not being updated too.
>
> Is there a standard procedure for this? I recall a
>discussion was here
> in May but missed its conclusions if there were any.
>
> Anyway this just shows how SVN sucks compared to e.g.
>Mercurial. I would
> have cloned my repo to freehg, let Nils verify it and
>then commit the
> changes - no patch review framework needed. ;)
>
> r.
Works for me with
r1205 | rc | 2008-08-07 12:29:20 +0200 (Thu, 07 Aug 2008)
| 2 lines
fixed test_umfpack.py for the latest SVN, added README
Thank you very much !
>>> from scikits import umfpack
>>> umfpack.test()
...........
----------------------------------------------------------------------
Ran 11 tests in 0.610s
OK
Cheers,
Nils
More information about the SciPy-Dev
mailing list