[SciPy-dev] Bug in weave, current SVN.

[Fernando Perez]

Hi all,

a bug recently popped up in weave, I was wondering if anyone would
mind the fix attached.  I can commit it, but since I don't regularly
touch the codebase, I prefer to check for approval from the regulars.

The problem was lines like:

code = arg_strings.join("")

which are backwards: join() must be used as string.join(list), not
list.join(string).  In addition, I added minimal docstrings and
rewrote the three little offending routines as list comprehensions,
which are faster and (to me) more readable.  I can also just commit
the bare fix without any 'improvements' if there are objections.

Thanks!

f
-------------- next part --------------
A non-text attachment was scrubbed...
Name: weave_fix.diff
Type: text/x-diff
Size: 1537 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/scipy-dev/attachments/20071113/e0159bf3/attachment.diff>