Pull request: fix tv denoise

Stéfan van der Walt stefan at sun.ac.za
Thu Jun 23 22:14:50 EDT 2011


On Jun 23, 2011 6:39 PM, "Tony Yu" <tsyu80 at gmail.com> wrote:
> The point of the patch isn't to set the order of arguments based on
preference, but instead, based on consistency. The other functions
(`tv_denoise` and `_tv_denoise_3d`) have `eps` followed by `weight`. Most
importantly, the arguments passed to `_tv_denoise_2d` are in this order, so
that  setting the keyword arg `eps` in `tv_denoise` actually adjusts the
`weight` argument of `_tv_denoise_2d` (and vice-versa). (See line 268 in
https://github.com/stefanv/scikits.image/blob/master/scikits/image/filter/tv_denoise.py
)

Thanks for looking at this issue, Tony and Maël. I'm currently travelling,
but will be able to merge pull requests over the weekend, if you can come to
an agreement on the best solution.

Thanks
Stéfan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scikit-image/attachments/20110624/bb7aa321/attachment.html>


More information about the scikit-image mailing list