RFR: Image-collection reader

Ralf Gommers ralf.gommers at googlemail.com
Mon Nov 8 10:24:55 EST 2010


2010/11/7 Stéfan van der Walt <stefan at sun.ac.za>:
> Hi Ralph
>
> On Sat, Nov 6, 2010 at 3:48 AM, Ralf Gommers
> <ralf.gommers at googlemail.com> wrote:
>> Can you explain why you set up the tests like that? It seems the test
>> is split over two files, with this change:
>>  +def imread_collection(x, conserve_memory=True):
>>  +    assert conserve_memory == False
>>  +    assert x == '*.png'
>> relying on a call from another file with the expected arguments. This
>> will be confusing I think.
>
> I wasn't sure how to test the plugin otherwise, but I'm open for ideas!

Now you're asking me to think:) It seems to be a reasonable solution
actually, maybe just a comment in _plugins/test_plugin.py that it's
called from io/tests/test_plugin.py would be useful.

Cheers,
Ralf



More information about the scikit-image mailing list