Why are unified diffs only "grudgingly" accepted?

Moshe Zadka moshez at math.huji.ac.il
Sun Aug 6 03:49:15 EDT 2000


On Sat, 5 Aug 2000, David Goodger wrote:

> In the patch submission guidelines (http://www.python.org/patches/), it is
> written:
> 
>     We like context diffs. We grudgingly accept unified diffs.
>     Straight ("ed-style") diffs are right out!
> 
> I understand why ed-style diffs are out, but why the are context diffs
> favoured over unified? I've always found unified (-u) diffs to be infinitely
> easier to read (by human eyes/brain) than context (-c) diffs.

Guido doesn't. That's reason enough really -- it's the same as asking "why
should I follow the Python style guidelines?": no real reason for that
style, but Guido likes it, and there has to be some consistency. 

> If unified
> diffs are OK for automatic patches, why only "grudgingly accept" them? A
> technical issue perhaps?

What do you mean "automatic patches"? no patch is automatically applied:
it is usually eye-balled by at least one, usually more, Python developer.
I used to like -u better myself, but I've gotten used to -c. I wouldn't
be able to switch every other day, so I'm glad there's a firm policy, even 
if Guido had to beat me several time with a cluestick until I'd gotten it
through my head.

following-the-bdfl-mindless-ly y'rs, Z.
--
Moshe Zadka <moshez at math.huji.ac.il>
There is no IGLU cabal.
http://advogato.org/person/moshez





More information about the Python-list mailing list