[Python-Dev] cpython: fixd refleak

Antoine Pitrou solipsis at pitrou.net
Thu Jun 13 23:42:21 CEST 2013


On Thu, 13 Jun 2013 23:39:49 +0200
Christian Heimes <christian at python.org> wrote:
> Am 13.06.2013 20:59, schrieb Antoine Pitrou:
> > How about
> > 
> >     return Py_BuildValue("NNNN", ofile_env, ofile, odir_env, odir);
> > 
> > ?
> 
> Oh right, I forgot about 'N'. The PyArg_Parse*() methods don't have it.
> 
> Do you want me to modify the code to use Py_BuildValue()?

Always better to use the simple form, IMO. Go for it!

Regards

Antoine.


More information about the Python-Dev mailing list