[Python-Dev] [Python-checkins] cpython (3.3): Issue #15814: Use hash function that is compatible with the equality

Antoine Pitrou solipsis at pitrou.net
Sat Nov 3 11:17:48 CET 2012


On Sat, 3 Nov 2012 10:59:23 +0100
Stefan Krah <stefan at bytereef.org> wrote:
> Nick Coghlan <ncoghlan at gmail.com> wrote:
> > > +        if (b == c):
> > > +            self.assertEqual(hash(b), hash(c))
> > 
> > These checks could do with a comment explaining why the if statements
> > are needed (I'm assuming something to do with memory order).
> 
> The checks aren't needed; they were supposed to spell out the equality-hash
> relationship.

Better use assertEqual(), then.

Regards

Antoine.




More information about the Python-Dev mailing list