[Python-Dev] cpython: Implemented PEP 405 (Python virtual environments).

[Antoine Pitrou]

On Sat, 26 May 2012 04:48:49 +0200
vinay.sajip <python-checkins at python.org> wrote:
> +_sys_home = getattr(sys, '_home', None)
> +if _sys_home and os.name == 'nt' and _sys_home.lower().endswith('pcbuild'):
> +    _sys_home = os.path.dirname(_sys_home)

What about pcbuild/amd64? Does this work on 64-bit builds?

> +_sys_home = getattr(sys, '_home', None)
> +if _sys_home and os.name == 'nt' and _sys_home.lower().endswith('pcbuild'):
> +    _sys_home = os.path.dirname(_sys_home)

Same question here.

> +#!/usr/bin/env python

I don't think there should be a shebang line in a test file.

> +#
> +# Copyright 2011 by Vinay Sajip. All Rights Reserved.
> +#
> +# Permission to use, copy, modify, and distribute this software and its
> +# documentation for any purpose and without fee is hereby granted,
> +# provided that the above copyright notice appear in all copies and that
> +# both that copyright notice and this permission notice appear in
> +# supporting documentation, and that the name of Vinay Sajip
> +# not be used in advertising or publicity pertaining to distribution
> +# of the software without specific, written prior permission.
> +# VINAY SAJIP DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE, INCLUDING
> +# ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL
> +# VINAY SAJIP BE LIABLE FOR ANY SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR
> +# ANY DAMAGES WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER
> +# IN AN ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT
> +# OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.

Why the copyright boilerplate?

> +# Use with a Python executable built from the Python fork at
> +#
> +# https://bitbucket.org/vinay.sajip/pythonv/ as follows:

This needs to be updated.

> +# You'll need an Internet connection (needed to download distribute_setup.py).
> +#
> +# The script will change to the environment's binary directory and run
> +#
> +# ./python distribute_setup.py

[...]

> +# This class will not be included in Python core; it's here for now to

Well... either the comment should be fixed or the class removed.

> +        # XXX This option will be removed.

> +        # XXX This will be changed to EnvBuilder

Same here.

> diff --git a/Lib/venv/scripts/nt/pysetup3.exe b/Lib/venv/scripts/nt/pysetup3.exe
> new file mode 100644
> index 0000000000000000000000000000000000000000..3f3c09ebc8e55f4ac3379041753cb34daef71892
> GIT binary patch

What's this file and how was it compiled?

Regards

Antoine.