[Python-Dev] cpython: Issue #1172711: Add 'long long' support to the array module.

Benjamin Peterson benjamin at python.org
Wed Sep 21 18:21:53 CEST 2011


2011/9/21 Georg Brandl <g.brandl at gmx.net>:
> Am 21.09.2011 15:25, schrieb Ezio Melotti:
>
>>> @@ -1205,6 +1214,18 @@
>>>       minitemsize = 4
>>>   tests.append(UnsignedLongTest)
>>>
>>> + at unittest.skipIf(not have_long_long, 'need long long support')
>>
>> I think this would read better with skipUnless and s/have/has/:
>>
>> @unittest.skipUnless(HAS_LONG_LONG, 'need long long support')
>
> I don't think so. "skip if not" reads pretty well for me, while I
> always have to think twice about "unless" -- may be a non-native-
> speaker thing.

You might also not program in Ruby enough. :)

-- 
Regards,
Benjamin


More information about the Python-Dev mailing list