[python-committers] Auto-merge the backport PR with one core dev approval and all passing CI

[Terry Reedy]

On 2/5/2018 9:34 AM, Nick Coghlan wrote:
> On 6 February 2018 at 00:07, Mariatta Wijaya <mariatta.wijaya at gmail.com> wrote:
>> Some notes and implicationss:
>>
>> - The expectation is that the commit message has already been cleaned up on
>> the master branch

and that Miss Islington has correctly copied the title and commit message.

>> - It already knows how to replace the # to GH- in the commit message
>> - miss-islington will need write access to CPython
>> - git log it will show miss-islington (bot) as the committer

I believe that this is already true unless there was a merge conflict.

>> - If you still want to do the merge yourself, then just don't approve
>> miss-islington's PR.

If I have to use cherry-picker because there is a merge conflict and I 
use cherry-picker --continue after resolving, then I am the author and I 
cannot approve my own PR.  The auto generated title has no relation to 
the title of the original merge, and the commit message is replaced by 
the reminder.  Finding the original commit message to paste in is not easy.

>> What does everyone here think about all that?

+1

> +1 from me, as being able to do the backport PR reviews as soon as
> Miss Islington creates them means I'll still have the original review
> fresh in my mind.

I have just started doing this, and approving when I am allowed.  I like 
it better than waiting, (or not reviewing).

Terry